Skip to content

RFC ethdev: add min/max MTU to device info

Ian Stokes dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ethdev: add min/max MTU to device infodoc/guides/rel_notes/deprecation.rst lib/librte_ethdev/rte_ethdev.c lib/librte_ethdev/rte_ethdev.h+9 -122 replies
2/6net/i40e: set min and max MTU for i40e devicesdrivers/net/i40e/i40e_ethdev.c+2 -00 replies
3/6net/i40e: set min and max MTU for i40e VF devicesdrivers/net/i40e/i40e_ethdev_vf.c+2 -00 replies
4/6net/ixgbe: set min and max MTU for ixgbe devicesdrivers/net/ixgbe/ixgbe_ethdev.c drivers/net/ixgbe/ixgbe_ethdev.h+6 -10 replies
5/6net/ixgbe: set min and max MTU for ixgbe VF devicesdrivers/net/ixgbe/ixgbe_ethdev.c+2 -10 replies
6/6net/e1000: set min and max MTU for igb devicesdrivers/net/e1000/e1000_ethdev.h drivers/net/e1000/igb_ethdev.c+11 -20 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchAndrew Rybchenko
1/6A-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/6] ethdev: add min/max MTU to device info

Building upon the discussion around [1], this series introduces MTU min and MTU max variables. It also provides updates to PMD implementations for ixgbe, i40e and IGB devices so that these variables are populated for use when retrieving device info.

This series was tested with OVS DPDK and functions as expected for the drivers listed below. But a wider selection of PMD drivers would have to adopt this to ensure jumbo frames functionality remains for drivers not modified in the series.

There is also ongoing discussion in [2] regarding overhead to be considered with MTU and how this may change from device to device, this series uses existing overhead assumptions.

There are also some tasks missing such as updating ethdev version and documentation that can be implemented in non RFC series if the approach is acceptable.

[1] http://mails.dpdk.org/archives/dev/2018-September/110959.html
[2] http://mails.dpdk.org/archives/dev/2019-February/124457.html

Ian Stokes (5):
net/i40e: set min and max MTU for i40e devices net/i40e: set min and max MTU for i40e VF devices net/ixgbe: set min and max MTU for ixgbe devices net/ixgbe: set min and max MTU for ixgbe VF devices net/e1000: set min and max MTU for igb devices

Stephen Hemminger (1):
ethdev: add min/max MTU to device info

 doc/guides/rel_notes/deprecation.rst | 12 ------------
 drivers/net/e1000/e1000_ethdev.h     |  6 ++++++
 drivers/net/e1000/igb_ethdev.c       |  7 +++++--
 drivers/net/i40e/i40e_ethdev.c       |  2 ++
 drivers/net/i40e/i40e_ethdev_vf.c    |  2 ++
 drivers/net/ixgbe/ixgbe_ethdev.c     |  7 +++++--
 drivers/net/ixgbe/ixgbe_ethdev.h     |  3 +++
 lib/librte_ethdev/rte_ethdev.c       |  7 +++++++
 lib/librte_ethdev/rte_ethdev.h       |  2 ++
 9 files changed, 32 insertions(+), 16 deletions(-)
Signature · 1 line
2.13.6