Skip to content

tracing/probes: uaccess: Add support user-space access

Masami Hiramatsu lkml 8 versions – In review

Get series with b4
b4 am 155789866428.26965.8344923934342528416.stgit@devnote2

Versions newest first · linked by author and title

  1. v9 Latest6 patches 6 repliesIn review
  2. v86 patches 5 repliesSuperseded
  3. v76 patches 7 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v6 RFC6 patches7 repliesSuperseded
v56 patches18 repliesSuperseded
v46 patches1 replySuperseded
v35 patches8 repliesSuperseded
v1 RFC4 patches13 repliesSuperseded

Changes in v9 from the cover letter

[3/6]
- Fix other style & coding issues (Thanks Ingo!)
- Update fetch_store_string() for style consistency.
[4/6]
- Remove an unneeded line break.
- Move || and && in if-condition at the end of line.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6x86/uaccess: Allow access_ok() in irq context if pagefault_disabledarch/x86/include/asm/uaccess.h include/linux/uaccess.h+7 -20 replies
2/6uaccess: Add non-pagefault user-space read functionsinclude/linux/uaccess.h mm/maccess.c+130 -60 replies
3/6tracing/probe: Add ustring type for user-space stringDocumentation/trace/kprobetrace.rst kernel/trace/trace.c kernel/trace/trace_kprobe.c +4 more+84 -100 replies
4/6tracing/probe: Support user-space dereferenceDocumentation/trace/kprobetrace.rst Documentation/trace/uprobetracer.rst kernel/trace/trace.c +5 more+81 -230 replies
5/6selftests/ftrace: Add user-memory access syntax testcasetools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc+32 -00 replies
6/6perf-probe: Add user memory access attribute supporttools/perf/Documentation/perf-probe.txt tools/perf/util/probe-event.c tools/perf/util/probe-event.h +3 more+35 -80 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSteven Rostedt (VMware)Ingo Molnar
SeriesA-b
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH -tip v9 0/6] tracing/probes: uaccess: Add support user-space access

Hi,

Here is the v9 series of probe-event to support user-space access. Previous version is here.

https://lkml.kernel.org/r/155741476971.28419.15837024173365724167.stgit@devnote2

In this version, I fixed more typos/style issues.

Changes in v9:
[3/6]
- Fix other style & coding issues (Thanks Ingo!)
- Update fetch_store_string() for style consistency.
[4/6]
- Remove an unneeded line break.
- Move || and && in if-condition at the end of line.

In summary, strncpy_from_user() should work as below

- strncpy_from_user() can access user memory with set_fs(USER_DS) in task context

- strncpy_from_user() can access kernel memory with set_fs(KERNEL_DS) in task context (e.g. devtmpfsd and init)

- strncpy_from_user() can access user/kernel memory (depends on DS) in IRQ context if pagefault is disabled. (both verified)

Note that this changes the warning behavior when CONFIG_DEBUG_ATOMIC_SLEEP=y, it still warns when __copy_from_user_inatomic() is called in IRQ context, but don't warn if pagefault is disabled because it will not sleep in atomic.

====
Kprobe event user-space memory access features:

For user-space access extension, this series adds 2 features, "ustring" type and user-space dereference syntax. "ustring" is used for recording a null-terminated string in user-space from kprobe events.

"ustring" type is easy, it is able to use instead of "string" type, so if you want to record a user-space string via "__user char *", you can use ustring type instead of string. For example,

echo 'p do_sys_open path=+0($arg2):ustring' >> kprobe_events

will record the path string from user-space.

The user-space dereference syntax is also simple. Thi just adds 'u' prefix before an offset value.

+|-u<OFFSET>(<FETCHARG>)

e.g. +u8(%ax), +u0(+0(%si))

This is more generic. If you want to refer the variable in user- space from its address or access a field in data structure in user-space, you need to use this.

For example, if you probe do_sched_setscheduler(pid, policy, param) and record param->sched_priority, you can add new probe as below;

p do_sched_setscheduler priority=+u0($arg3)

Actually, with this feature, "ustring" type is not absolutely necessary, because these are same meanings.

+0($arg2):ustring == +u0($arg2):string

Note that kprobe event provides these methods, but it doesn't change it from kernel to user automatically because we do not know whether the given address is in userspace or kernel on some arch.

Thank you,

---

Masami Hiramatsu (6):
x86/uaccess: Allow access_ok() in irq context if pagefault_disabled
uaccess: Add non-pagefault user-space read functions tracing/probe: Add ustring type for user-space string tracing/probe: Support user-space dereference selftests/ftrace: Add user-memory access syntax testcase
perf-probe: Add user memory access attribute support

 Documentation/trace/kprobetrace.rst                |   28 ++++-
 Documentation/trace/uprobetracer.rst               |   10 +-
 arch/x86/include/asm/uaccess.h                     |    4 -
 include/linux/uaccess.h                            |   19 +++
 kernel/trace/trace.c                               |    7 +
 kernel/trace/trace_kprobe.c                        |   48 +++++++-
 kernel/trace/trace_probe.c                         |   37 +++++-
 kernel/trace/trace_probe.h                         |    3 
 kernel/trace/trace_probe_tmpl.h                    |   36 +++++-
 kernel/trace/trace_uprobe.c                        |   19 +++
 mm/maccess.c                                       |  122 +++++++++++++++++++-
 tools/perf/Documentation/perf-probe.txt            |    3 
 tools/perf/util/probe-event.c                      |   11 ++
 tools/perf/util/probe-event.h                      |    2 
 tools/perf/util/probe-file.c                       |    7 +
 tools/perf/util/probe-file.h                       |    1 
 tools/perf/util/probe-finder.c                     |   19 ++-
 .../ftrace/test.d/kprobe/kprobe_args_user.tc       |   32 +++++
 18 files changed, 364 insertions(+), 44 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc

--
Masami Hiramatsu (Linaro) <[email protected]>