Skip to content

iommu/arm-smmu: Split pagetable support

Jordan Crouse linux-arm-kernel linux-arm-msm linux-iommu lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 3/32 patches 6 repliesIn review
  2. v3 posting 2/31 of 2 patches 0 repliesSuperseded
  3. v2 posting 3/33 patches 3 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v2 posting 2/33 patches0 repliesSuperseded
v3 posting 1/316 patches0 repliesSuperseded
v2 posting 1/315 patches4 repliesSuperseded
v1 RFC15 patches7 repliesSuperseded

Patches in v3 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iommu/io-pgtable-arm: Add support for ARM_ADRENO_GPU_LPAE io-pgtable formatdrivers/iommu/io-pgtable-arm.c drivers/iommu/io-pgtable.c include/linux/io-pgtable.h+202 -151 reply
2/2iommu/arm-smmu: Add support for Adreno GPU pagetable formatsdrivers/iommu/arm-smmu.c+7 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] iommu/arm-smmu: Split pagetable support

(Sigh, resend. I freaked out my SMTP server)

This is part of an ongoing evolution for enabling split pagetable support for arm-smmu. Previous versions can be found [1].

In the discussion for v2 Robin pointed out that this is a very Adreno specific use case and that is exactly true. Not only do we want to configure and use a pagetable in the TTBR1 space, we also want to configure the TTBR0 region but not allocate a pagetable for it or touch it until the GPU hardware does so. As much as I want it to be a generic concept it really isn't.

This revision leans into that idea. Most of the same io-pgtable code is there but now it is wrapped as an Adreno GPU specific format that is selected by the compatible string in the arm-smmu device.

Additionally, per Robin's suggestion we are skipping creating a TTBR0 pagetable to save on wasted memory.

This isn't as clean as I would like it to be but I think that this is a better direction than trying to pretend that the generic format would work.

I'm tempting fate by posting this and then taking some time off, but I wanted to try to kick off a conversation or at least get some flames so I can try to refine this again next week. Please take a look and give some advice on the direction.

[1] https://patchwork.freedesktop.org/series/63403/

Jordan

Jordan Crouse (2):
iommu/io-pgtable-arm: Add support for ARM_ADRENO_GPU_LPAE io-pgtable
format
iommu/arm-smmu: Add support for Adreno GPU pagetable formats

 drivers/iommu/arm-smmu.c       |   8 +-
 drivers/iommu/io-pgtable-arm.c | 214 ++++++++++++++++++++++++++++++++++++++---
 drivers/iommu/io-pgtable.c     |   1 +
 include/linux/io-pgtable.h     |   2 +
 4 files changed, 209 insertions(+), 16 deletions(-)
Signature · 1 line
2.7.4