Skip to content

more reconnect fixes

Pavel Shilovsky linux-cifs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3CIFS: Only send SMB2_NEGOTIATE command on new TCP connectionsfs/cifs/smb2transport.c+8 -00 replies
2/3CIFS: Return -EAGAIN instead of -ENOTSOCKfs/cifs/transport.c+2 -10 replies
3/3CIFS: Mask off signals when sending SMB packetsfs/cifs/transport.c+38 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] more reconnect fixes

The patchset has 3 patches that fix some problems related to network reconnects.

The first patch fixes out-of-order requests sent over newly established TCP connections, in particular it prevents sending anything rather than SMB2_NEGOTIATE.

The second patch changes the return code from -ENOTSOCK to -EAGAIN for TCP connections that are in the middle of reconnect.

The third patch is a new version of the patch posted previously. Since we are doing socket sends in the same thread with a syscall we might experience interrupts due to signals. If such signals come while we are in the middle of sending SMB packet to the server, we may end up with partial sends and unnecessary network reconnects thus overloading the server. The patch masks off signals during the whole packet send thus avoiding interrupts and reconnects.

Pavel Shilovsky (3):
CIFS: Only send SMB2_NEGOTIATE command on new TCP connections
CIFS: Return -EAGAIN instead of -ENOTSOCK
CIFS: Mask off signals when sending SMB packets

 fs/cifs/smb2transport.c |  8 ++++++++
 fs/cifs/transport.c     | 44 ++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 48 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4