Skip to content

RFC tracing: Use common error_log with probe events

Masami Hiramatsu linux-rt-users lkml 2 versions – New

Get series with b4
b4 am 155253778926.14922.14048967363017104338.stgit@devnote2

Versions newest first · linked by author and title

  1. v2 RFC Latest7 patches 0 repliesNew
  2. v1 RFC7 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tracing/probe: Check maxactive error caseskernel/trace/trace_kprobe.c+7 -30 replies
2/7tracing/probe: Check event name length correctlykernel/trace/trace_probe.c+7 -10 replies
3/7tracing/probe: Check the size of argument name and bodykernel/trace/trace_probe.c kernel/trace/trace_probe.h+3 -00 replies
4/7tracing/probe: Check event/group naming rule at parsingkernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_uprobe.c+10 -100 replies
5/7tracing/probe: Verify alloc_trace_*probe() resultkernel/trace/trace_kprobe.c kernel/trace/trace_uprobe.c+4 -30 replies
6/7tracing: Use tracing error_log with probe eventskernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+348 -1240 replies
7/7selftests/ftrace: Add error_log testcase for probe errorstools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc+124 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/7] tracing: Use common error_log with probe events

Hi,

Here is the 2nd version of using common error_log with probe events. Previous version is here.

http://lkml.kernel.org/r/155248005229.10815.334731901778152247.stgit@devnote2

In this version, I've updated some error messages according to Steve's comment, adjust some error position, and update testcase to simplify a bit.

- [4/7]: Update error message according to Steve's comment (Thanks!)
- [6/7]: Update error message, adjust error positions, and add uprobe errors
- [7/7]: Specify error position in command string by "^".
Clear error_log right before writing command.
Add uprobe syntax error checker

Thank you,

---

Masami Hiramatsu (7):
tracing/probe: Check maxactive error cases tracing/probe: Check event name length correctly tracing/probe: Check the size of argument name and body tracing/probe: Check event/group naming rule at parsing tracing/probe: Verify alloc_trace_*probe() result
tracing: Use tracing error_log with probe events selftests/ftrace: Add error_log testcase for probe errors

 kernel/trace/trace_kprobe.c                        |   90 ++++--
 kernel/trace/trace_probe.c                         |  282 +++++++++++++++-----
 kernel/trace/trace_probe.h                         |   78 +++++-
 kernel/trace/trace_uprobe.c                        |   52 ++--
 .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc   |   93 +++++++
 .../ftrace/test.d/kprobe/uprobe_syntax_errors.tc   |   31 ++
 6 files changed, 494 insertions(+), 132 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
 create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc

--
Masami Hiramatsu <[email protected]>