Skip to content

Add Multi Segment Gamma Support

Uma Shankar dri-devel intel-gfx 3 versions – NAK

Status from this message: Nack, this doesn't seem like a sensible idea. We already guard it

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 14 repliesNAK
  2. v27 patches 20 repliesSuperseded
  3. v1 RFC7 patches 16 repliesSuperseded

Patches in v3

#Subject and filesSizeRepliesApplied
1/7drm: Add gamma mode propertydrivers/gpu/drm/drm_atomic_uapi.c drivers/gpu/drm/drm_color_mgmt.c include/drm/drm_color_mgmt.h +3 more+141 -01 reply
2/7drm/i915: Define color lut range structuredrivers/gpu/drm/i915/intel_color.c+562 -40 replies
3/7drm/i915/icl: Add register definitions for Multi Segmented gammadrivers/gpu/drm/i915/i915_reg.h+17 -00 replies
4/7drm/i915/icl: Add support for multi segmented gamma modedrivers/gpu/drm/i915/intel_color.c include/drm/drm_crtc.h+165 -40 replies
5/7drm/i915: Attach gamma mode propertydrivers/gpu/drm/i915/intel_color.c drivers/gpu/drm/i915/intel_display.c+6 -00 replies
6/7drm: Add Client Cap for advance gamma modedrivers/gpu/drm/drm_atomic_uapi.c drivers/gpu/drm/drm_ioctl.c include/drm/drm_atomic.h +3 more+26 -08 replies
7/7drm/i915: Enable advance gamma modedrivers/gpu/drm/i915/intel_color.c+9 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [v3 0/7] Add Multi Segment Gamma Support

This series adds support for programmable gamma modes and exposes a property interface for the same. Also added, support for multi segment gamma mode introduced in ICL+

It creates GAMMA_MODE property interface. This is an enum property with values as blob_id's and exposes
the various gamma modes supported and the lut ranges Getting the blob id in userspace, user can get the mode supported and also the range of gamma mode supported with number of lut coefficients. It can then set one of the modes using this enum property.

Lut values will be sent through already available GAMMA_LUT blob property.

It also introduces a CLIENT CAP for advanced GAMMA_MODE.
This is for user to set the and use advance gamma mode and older
userspace can continue using the legacy paths.

v2: Used Ville's design and approach to define the interfaces. Addressed Matt Roper's review feedback and re-ordered the patches.

v3: Converged to 1 property interface and introduced a Client cap as suggested by Ville. Fixed review comments received.

Uma Shankar (5):
drm/i915/icl: Add register definitions for Multi Segmented gamma drm/i915/icl: Add support for multi segmented gamma mode drm/i915: Attach gamma mode property
drm: Add Client Cap for advance gamma mode
drm/i915: Enable advance gamma mode

Ville Syrjälä (2):
drm: Add gamma mode property
drm/i915: Define color lut range structure

 drivers/gpu/drm/drm_atomic_uapi.c    |   8 +
 drivers/gpu/drm/drm_color_mgmt.c     |  77 ++++
 drivers/gpu/drm/drm_ioctl.c          |   5 +
 drivers/gpu/drm/i915/i915_reg.h      |  17 +
 drivers/gpu/drm/i915/intel_color.c   | 735 ++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_display.c |   3 +
 include/drm/drm_atomic.h             |   1 +
 include/drm/drm_color_mgmt.h         |   8 +
 include/drm/drm_crtc.h               |  17 +
 include/drm/drm_file.h               |   8 +
 include/drm/drm_mode_config.h        |   6 +
 include/uapi/drm/drm.h               |   2 +
 include/uapi/drm/drm_mode.h          |  38 ++
 13 files changed, 918 insertions(+), 7 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel