Skip to content

RFC Kselftest shell (or even C) API

zohar at linux.ibm.com (Mimi Zohar) linux-kselftest 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] Kselftest shell (or even C) API

Hi Mimi, Shuah,

Quoted 16 lines

Hi Petr, Shuah,

Quoted 5 lines · Petr Vorel

Hi,

this is a draft trying to define some API in order to remove some redundancy from kselftest shell scripts. Existing kselftest.h already defines some sort of API for C, there is none for shell.

Shuah, when the tests were in the selftests/ima directory I was planning on including them in my pull request; and then they moved to selftests/kexec.  As they were still IMA related, I was still shepherding them and planned on including them in my pull request. (Is this Okay?  Your Review/Ack would be much appreciated.)  This patch set, however, introduces a set of "common" set of kselftest functions.

Quoted 3 lines

Originally, you suggested deferring defining a set of "common" kselftests functions to prevent delaying upstreaming the tests.  With these patches, that time is here.  How do you want to handle this?

I agree with separation of common kselftests functions / proper API effort. kexec tests are ready and IMHO should not be delayed with this effort. "common functions" proposed by this patchset are more for to start a discussion about it, what I brought doesn't help much. Proper design takes some time.

Quoted 3 lines

Thanks,

Mimi

Kind regards,
Petr