Skip to content

Fix two bugs of switchtec module

Wesley Sheng linux-pci lkml 2 versions – Applied

Status from this message: Applied to pci/switchtec for v5.2, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- rewrapped the commit message of [PATCH 1/2] into one paragraph

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2switchtec: Fix false maximum supported PCIe function number issuedrivers/pci/switch/switchtec.c include/linux/switchtec.h include/uapi/linux/switchtec_ioctl.h+40 -143 replies
2/2switchtec: Fix unintended mask of MRPC eventdrivers/pci/switch/switchtec.c+2 -11 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLogan Gunthorpe
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fix two bugs of switchtec module

Hi, Everyone,

This patch series fix two bugs of switchtec module.

The first is introduced by device spec definition issue: the maximum supported PCIe function number by hardware should be 255 instead of the false number of 48. Rectify it in driver and for backward compatible, a new ioctl and corresponding data structure are created, while keep the deprecated one.

The second is MRPC event unintentionally masked at corner case. Fix this bug by skipping the mask operation for MRPC event in event ISR like what we already do for LINK event.

Regard,
Wesley

--

Changed since v1:
- rewrapped the commit message of [PATCH 1/2] into one paragraph

--

Wesley Sheng (2):
switchtec: Fix false maximum supported PCIe function number issue
switchtec: Fix unintended mask of MRPC event

 drivers/pci/switch/switchtec.c       | 42 +++++++++++++++++++++++++-----------
 include/linux/switchtec.h            |  2 +-
 include/uapi/linux/switchtec_ioctl.h | 13 ++++++++++-
 3 files changed, 42 insertions(+), 15 deletions(-)
Signature · 1 line
2.7.4