Skip to content

drm/i915: adding state checker for gamma lut values

Swati Sharma intel-gfx 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest8 patches 2 repliesIn review
  2. v911 patches 12 repliesSuperseded
  3. v88 of 10 patches 15 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v7 posting 2/212 patches10 repliesSuperseded
v7 posting 1/212 patches0 repliesSuperseded
v612 patches5 repliesSuperseded
v511 patches9 repliesSuperseded
v411 patches3 repliesSuperseded
v32 of 11 patches3 repliesSuperseded
v2 posting 2/211 patches0 repliesSuperseded
v2 posting 1/211 patches0 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/display: Add func to get gamma bit precisiondrivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/display/intel_color.h+61 -00 replies
2/8drm/i915/display: Add debug log for color parametersdrivers/gpu/drm/i915/display/intel_display.c+9 -00 replies
3/8drm/i915/display: Add func to compare hw/sw gamma lutdrivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/display/intel_color.h+78 -00 replies
4/8drm/i915/display: Add macro to compare gamma hw/sw lutdrivers/gpu/drm/i915/display/intel_display.c+25 -00 replies
5/8drm/i915/display: Extract i9xx_read_luts()drivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/i915_reg.h+57 -00 replies
6/8drm/i915/display: Extract ilk_read_luts()drivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/i915_reg.h+47 -10 replies
7/8drm/i915/display: Extract glk_read_luts()drivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/i915_reg.h+52 -20 replies
8/8FOR_TESTING_ONLY: Print rgb values of hw and sw blobsdrivers/gpu/drm/i915/display/intel_color.c+2 -00 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by.

PatchJani NikulaUma Shankar
1/8
2/8R-b
3/8
4/8R-b
5/8R-b
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [v10][PATCH 0/8] drm/i915: adding state checker for gamma lut values

In this patch series, added state checker to validate gamma (8BIT and 10BIT).This reads hardware state, and compares the originally requested state(s/w) to the state read from the hardware. This is done for legacy, ilk, glk and their variant platforms. Rest of the platforms will be enabled on top of this later.

Intentionally, excluded bdw and ivb since they have spilt gamma mode; for which degamma read outs are required (which I think shouldn't be included in this patch series). Will include after degamma state checker is completed.

v1: -Implementation done for legacy platforms
(removed all the placeholders) (Jani)
v2: -Restructured code and created platform specific patch series for
gamma validation

v3:  -Rebase
v4:  -Minor changes-function name changes mainly
v5:  -Added degamma validation (Ville)
v6:  -Removed degamma changes, debugging was becoming difficult

-Added function to assign bit_precision for gamma/degamma
lut values /platform
-Added debug info into intel_dump_pipe_config() (Jani)
v7: -Added platform specific functions to compute gamma bit precision
on the basis of GAMMA_MODE (Ville)
-Corrected checkpatch warnings
v8: -Restructured code
-Removed bdw and ivb platform state checker
v9: -Obliged 80 character word limit [Uma]
-Added state checker for icl
-Added bit precision func for icl
v10: -Dropped multi-seg gamma mode [Jani]
-Enabled basic infrastructure only [Jani]
-Minor fixes [Jani]

Swati Sharma (8):
drm/i915/display: Add func to get gamma bit precision drm/i915/display: Add debug log for color parameters drm/i915/display: Add func to compare hw/sw gamma lut drm/i915/display: Add macro to compare gamma hw/sw lut drm/i915/display: Extract i9xx_read_luts() drm/i915/display: Extract ilk_read_luts() drm/i915/display: Extract glk_read_luts()
FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

 drivers/gpu/drm/i915/display/intel_color.c   | 284 ++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_color.h   |   7 +
 drivers/gpu/drm/i915/display/intel_display.c |  34 ++++
 drivers/gpu/drm/i915/i915_reg.h              |   9 +
 4 files changed, 331 insertions(+), 3 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx