Skip to content

KVM: arm64: SVE cleanups

Dave Martin kvmarm linux-arm-kernel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 8 repliesIn review
  2. v114 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14arm64/sve: Clarify vq map semanticsarch/arm64/include/asm/fpsimd.h arch/arm64/kernel/fpsimd.c+6 -50 replies
2/14KVM: arm/arm64: Demote kvm_arm_init_arch_resources() to just set up SVEarch/arm/include/asm/kvm_host.h arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/reset.c +1 more+4 -40 replies
3/14KVM: arm: Make vcpu finalization stubs into inline functionsarch/arm/include/asm/kvm_host.h+9 -20 replies
4/14KVM: arm64/sve: sys_regs: Demote redundant vcpu_has_sve() checks to WARNsarch/arm64/kvm/sys_regs.c+2 -20 replies
5/14KVM: arm64/sve: Clean up UAPI register ID definitionsarch/arm64/include/uapi/asm/kvm.h arch/arm64/kvm/guest.c+32 -90 replies
6/14KVM: arm64/sve: Miscellaneous tidyups in guest.carch/arm64/kvm/guest.c+5 -130 replies
7/14KVM: arm64/sve: Make register ioctl access errors more consistentarch/arm64/kvm/guest.c+31 -214 replies
8/14KVM: arm64/sve: WARN when avoiding divide-by-zero in sve_reg_to_region()arch/arm64/kvm/guest.c+1 -10 replies
9/14KVM: arm64/sve: Simplify KVM_REG_ARM64_SVE_VLS array sizingDocumentation/virtual/kvm/api.txt arch/arm64/include/uapi/asm/kvm.h arch/arm64/kvm/guest.c+14 -80 replies
10/14KVM: arm64/sve: Explain validity checks in set_sve_vls()arch/arm64/kvm/guest.c+7 -00 replies
11/14KVM: arm/arm64: Clean up vcpu finalization function parameter namingarch/arm/include/asm/kvm_host.h arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/reset.c+4 -40 replies
12/14KVM: Clarify capability requirements for KVM_ARM_VCPU_FINALIZEDocumentation/virtual/kvm/api.txt+2 -30 replies
13/14KVM: Clarify KVM_{SET, GET}_ONE_REG error code documentationDocumentation/virtual/kvm/api.txt+9 -50 replies
14/14KVM: arm64: Clarify access behaviour for out-of-range SVE register slice IDsDocumentation/virtual/kvm/api.txt+3 -20 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrew JonesAlex Bennée
SeriesR-b
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] KVM: arm64: SVE cleanups

This series contains some cleanups applicable to the SVE KVM support patches merged into kvmarm/next. These arose from Andrew Jones' review.

Apart from some minor changes to error codes and checking, these are mostly cosmetic / sytlistic changes only.

The patches are based on
git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next 5d8d4af24460 ("arm64: KVM: Fix system register enumeration")

This series in git:
git://linux-arm.org/linux-dm.git sve-kvm-fixes/v2/head
http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve-kvm-fixes/v2/head

Tested with qemu and kvmtool on ThunderX2, and with kvmtool on the Arm Fast model (to exercise SVE support).

Some additional manual testing was done to exercise the updated error behaviours when accessing the SVE registers via ioctl.

Dave Martin (14):
arm64/sve: Clarify vq map semantics
KVM: arm/arm64: Demote kvm_arm_init_arch_resources() to just set up
SVE
KVM: arm: Make vcpu finalization stubs into inline functions
KVM: arm64/sve: sys_regs: Demote redundant vcpu_has_sve() checks to
WARNs
KVM: arm64/sve: Clean up UAPI register ID definitions
KVM: arm64/sve: Miscellaneous tidyups in guest.c
KVM: arm64/sve: Make register ioctl access errors more consistent
KVM: arm64/sve: WARN when avoiding divide-by-zero in

    sve_reg_to_region()

KVM: arm64/sve: Simplify KVM_REG_ARM64_SVE_VLS array sizing
KVM: arm64/sve: Explain validity checks in set_sve_vls()
KVM: arm/arm64: Clean up vcpu finalization function parameter naming
KVM: Clarify capability requirements for KVM_ARM_VCPU_FINALIZE
KVM: Clarify KVM_{SET,GET}_ONE_REG error code documentation
KVM: arm64: Clarify access behaviour for out-of-range SVE register
slice IDs

 Documentation/virtual/kvm/api.txt | 24 ++++++-----
 arch/arm/include/asm/kvm_host.h   | 13 ++++--
 arch/arm64/include/asm/fpsimd.h   |  4 --
 arch/arm64/include/asm/kvm_host.h |  4 +-
 arch/arm64/include/uapi/asm/kvm.h | 32 ++++++++++----
 arch/arm64/kernel/fpsimd.c        |  7 ++-
 arch/arm64/kvm/guest.c            | 91 +++++++++++++++++++++++----------------
 arch/arm64/kvm/reset.c            |  6 +--
 arch/arm64/kvm/sys_regs.c         |  4 +-
 virt/kvm/arm/arm.c                |  2 +-
 10 files changed, 116 insertions(+), 71 deletions(-)
Signature · 38 lines
2.1.4

@@@@

Dave Martin (14):
  arm64/sve: Clarify vq map semantics
  KVM: arm/arm64: Demote kvm_arm_init_arch_resources() to just set up
    SVE
  KVM: arm: Make vcpu finalization stubs into inline functions
  KVM: arm64/sve: sys_regs: Demote redundant vcpu_has_sve() checks to
    WARNs
  KVM: arm64/sve: Clean up UAPI register ID definitions
  KVM: arm64/sve: Miscellaneous tidyups in guest.c
  KVM: arm64/sve: Make register ioctl access errors more consistent
  KVM: arm64/sve: WARN when avoiding divide-by-zero in
    sve_reg_to_region()
  KVM: arm64/sve: Simplify KVM_REG_ARM64_SVE_VLS array sizing
  KVM: arm64/sve: Explain validity checks in set_sve_vls()
  KVM: arm/arm64: Clean up vcpu finalization function parameter naming
  KVM: Clarify capability requirements for KVM_ARM_VCPU_FINALIZE
  KVM: Clarify KVM_{SET,GET}_ONE_REG error code documentation
  KVM: arm64: Clarify access behaviour for out-of-range SVE register
    slice IDs

 Documentation/virtual/kvm/api.txt | 34 +++++++++------
 arch/arm/include/asm/kvm_host.h   | 13 ++++--
 arch/arm64/include/asm/fpsimd.h   |  4 --
 arch/arm64/include/asm/kvm_host.h |  4 +-
 arch/arm64/include/uapi/asm/kvm.h | 37 ++++++++++++----
 arch/arm64/kernel/fpsimd.c        |  7 ++-
 arch/arm64/kvm/guest.c            | 89 +++++++++++++++++++++++----------------
 arch/arm64/kvm/reset.c            |  6 +--
 arch/arm64/kvm/sys_regs.c         |  4 +-
 virt/kvm/arm/arm.c                |  2 +-
 10 files changed, 125 insertions(+), 75 deletions(-)

-- 
2.1.4