Skip to content

netfilter: header cleanup

Paul Gortmaker netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3netfilter: nf_tables: relocate header content to consumerinclude/net/netfilter/nf_tables.h net/netfilter/nft_dynset.c+17 -170 replies
2/3netfilter: nf_tables: fix implicit include of module.hnet/netfilter/nf_tables_set_core.c+1 -00 replies
3/3netfilter: nf_tables: drop include of module.h from nf_tables.hinclude/net/netfilter/nf_tables.h+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH -next 0/3] netfilter: header cleanup

Having core header files in include/linux that in turn include other headers with a high number of includes implicitly degenerates into a formalism that hides what amounts to #include <linux/everything.h>

Some headers, like module.h and device.h are good examples that will essentially drag in almost everything.

There is nothing module specific about netfilter, but before we try and stop nf_tables.h from including module.h, we have to fix two instances of code which are implicitly relying on that module.h inclusion, so as to not introduce build regressions.

---

Cc "David S. Miller" <[email protected]>
Cc Florian Westphal <[email protected]>
Cc Jozsef Kadlecsik <[email protected]>
Cc Pablo Neira Ayuso <[email protected]>

Paul Gortmaker (3):
netfilter: nf_tables: relocate header content to consumer
netfilter: nf_tables: fix implicit include of module.h
netfilter: nf_tables: drop include of module.h from nf_tables.h

 include/net/netfilter/nf_tables.h  | 20 ++------------------
 net/netfilter/nf_tables_set_core.c |  1 +
 net/netfilter/nft_dynset.c         | 17 +++++++++++++++++
 3 files changed, 20 insertions(+), 18 deletions(-)
Signature · 1 line
2.7.4