Skip to content

drm: Kirin driver cleanups to prep for Kirin960 support

John Stultz dri-devel lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest25 patches 3 repliesIn review
  2. v425 patches 2 repliesSuperseded
  3. v3 posting 2/226 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v3 posting 1/226 patches1 replySuperseded
v125 patches18 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25drm: kirin: Fix for hikey620 display offset problemdrivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+23 -00 replies
2/25drm: kirin: Remove HISI_KIRIN_DW_DSI config optiondrivers/gpu/drm/hisilicon/kirin/Kconfig drivers/gpu/drm/hisilicon/kirin/Makefile+2 -110 replies
3/25drm: kirin: Remove unreachable returndrivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c+0 -20 replies
4/25drm: kirin: Remove uncessary parameter indirectiondrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+5 -70 replies
5/25drm: kirin: Remove out_format from ade_crtcdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+3 -60 replies
6/25drm: kirin: Rename ade_plane to kirin_planedrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+29 -280 replies
7/25drm: kirin: Rename ade_crtc to kirin_crtcdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+37 -370 replies
8/25drm: kirin: Dynamically allocate the hw_ctxdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+24 -150 replies
9/25drm: kirin: Move request irq handle in ade hw ctx allocdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+17 -120 replies
10/25drm: kirin: Move workqueue to ade_hw_ctx structuredrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+5 -70 replies
11/25drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.hdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+26 -250 replies
12/25drm: kirin: Reanme dc_ops to kirin_drm_datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+11 -110 replies
13/25drm: kirin: Move ade crtc/plane help functions to driver_datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+15 -50 replies
14/25drm: kirin: Move channel formats to driver datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+10 -230 replies
15/25drm: kirin: Move mode config function to driver_datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+12 -80 replies
16/25drm: kirin: Move plane number and primay plane in driver datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+15 -80 replies
17/25drm: kirin: Move config max_width and max_height to driver datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+9 -120 replies
18/25drm: kirin: Move drm driver to driver datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+26 -340 replies
19/25drm: kirin: Add register connect helper functions in drm initdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+45 -01 reply
20/25drm: kirin: Rename plane_init and crtc_initdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+10 -70 replies
21/25drm: kirin: Fix dev->driver_data settingdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c+1 -30 replies
22/25drm: kirin: Make driver_data variable non-globaldrivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c+24 -190 replies
23/25drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver datadrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+13 -10 replies
24/25drm: kirin: Pass driver data to crtc init and plane initdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c+13 -100 replies
25/25drm: kirin: Move ade drm init to kirin drm drvdrivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h+129 -1420 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchXinliang LiuSam Ravnborg
1/25A-b R-b
2/25A-b R-b
3/25A-b R-b
4/25A-b R-b
5/25A-b R-b
6/25A-b R-b
7/25A-b R-b
8/25A-b R-b
9/25A-b R-b
10/25A-b R-b
11/25A-b R-b
12/25A-b R-b
13/25A-b R-b
14/25A-b R-b
15/25A-b R-b
16/25A-b R-b
17/25A-b R-b
18/25A-b R-b
19/25A-b R-b
20/25A-b R-b
21/25A-b R-b
22/25A-b R-b
23/25A-b R-b
24/25A-b R-b
25/25A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/25] drm: Kirin driver cleanups to prep for Kirin960 support

Sending this out again (apologies!), to address a few issues Sam found.

This patchset contains one fix (in the front, so its easier to eventually backport), and a series of changes from YiPing to refactor the kirin drm driver so that it can be used on both kirin620 based devices (like the original HiKey board) as well as kirin960 based devices (like the HiKey960 board).

The full kirin960 drm support is still being refactored, but as this base kirin rework was getting to be substantial, I wanted to send out the first chunk, so that the review burden wasn't overwhelming.

The full HiKey960 patch stack can be found here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey960-mainline-WIP

thanks
-john

New in v5:
* Whitespace changes and few logic simplifications to get checkpatch.pl --strict to pass, as noted by Sam
* Fix for one of my patches which broke building the kirin driver as a module. Again noted by Sam.

Cc Rongrong Zou <[email protected]>
Cc Xinliang Liu <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc dri-devel <[email protected]>
Cc Sam Ravnborg <[email protected]>

Da Lv (1):
drm: kirin: Fix for hikey620 display offset problem

John Stultz (3):
drm: kirin: Remove HISI_KIRIN_DW_DSI config option
drm: kirin: Remove unreachable return
drm: kirin: Move workqueue to ade_hw_ctx structure

Xu YiPing (21):
drm: kirin: Remove uncessary parameter indirection
drm: kirin: Remove out_format from ade_crtc
drm: kirin: Rename ade_plane to kirin_plane
drm: kirin: Rename ade_crtc to kirin_crtc
drm: kirin: Dynamically allocate the hw_ctx
drm: kirin: Move request irq handle in ade hw ctx alloc
drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to
kirin_drm_drv.h
drm: kirin: Reanme dc_ops to kirin_drm_data
drm: kirin: Move ade crtc/plane help functions to driver_data
drm: kirin: Move channel formats to driver data
drm: kirin: Move mode config function to driver_data
drm: kirin: Move plane number and primay plane in driver data
drm: kirin: Move config max_width and max_height to driver data
drm: kirin: Move drm driver to driver data
drm: kirin: Add register connect helper functions in drm init
drm: kirin: Rename plane_init and crtc_init
drm: kirin: Fix dev->driver_data setting
drm: kirin: Make driver_data variable non-global
drm: kirin: Add alloc_hw_ctx/clean_hw_ctx ops in driver data
drm: kirin: Pass driver data to crtc init and plane init
drm: kirin: Move ade drm init to kirin drm drv

 drivers/gpu/drm/hisilicon/kirin/Kconfig       |  10 +-
 drivers/gpu/drm/hisilicon/kirin/Makefile      |   3 +-
 .../gpu/drm/hisilicon/kirin/kirin_ade_reg.h   |   1 +
 .../gpu/drm/hisilicon/kirin/kirin_drm_ade.c   | 351 +++++++-----------
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   | 250 +++++++++----
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.h   |  48 ++-
 6 files changed, 367 insertions(+), 296 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel