Enable new L1 security for Vega10 SR-IOV
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm/amdgpu: init vega10 SR-IOV reg access modedrivers/ drivers/ drivers/ +1 more | +77 | 0 replies | |
| 2/9 | drm/amdgpu: initialize PSP before IH under SR-IOVdrivers/ drivers/ | +19 | 0 replies | |
| 3/9 | drm/amdgpu: Add new PSP cmd GFX_CMD_ID_PROG_REGdrivers/ | +8 | 0 replies | |
| 4/9 | drm/amdgpu: implement PSP cmd GFX_CMD_ID_PROG_REGdrivers/ drivers/ | +38 | 0 replies | |
| 5/9 | drm/amdgpu: call psp to progrm ih cntl in SR-IOVdrivers/ | +82 | 1 reply | |
| 6/9 | drm/amdgpu: Support PSP VMR ring for Vega10 VFdrivers/ | +99 | 0 replies | |
| 7/9 | drm/amdgpu: Skip setting some regs under Vega10 VFdrivers/ drivers/ drivers/ +2 more | +50 | 1 reply | |
| 8/9 | drm/amdgpu: add basic func for RLC program regdrivers/ | +56 | 0 replies | |
| 9/9 | drm/amdgpu: RLC to program regs for Vega10 SR-IOVdrivers/ drivers/ drivers/ +1 more | +85 | 0 replies |
Reviews trailers per patch
2 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Alex Deucher |
|---|---|
| Series | R-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | R-b |
| 6/9 | |
| 7/9 | R-b |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] Enable new L1 security for Vega10 SR-IOV
To support new Vega10 SR-IOV L1 security, KMD need some modifications
1: Due to the new features supported in FW(PSP, RLC, etc),
for register access during initialization, we have more modes:
1), request PSP to program
2), request RLC to program
3), request SR-IOV host driver to program and skip
programming them in amdgpu
4), Legacy MMIO access
We will try to read the firmware version to see which mode is support
2: If PSP FW support to program some registers, such as IH,
we need:
1), initialize PSP before IH
2), send the specific command to PSP
3: Support VMR ring. VMR ring, compared with physical platform
TMR ring, the program sequence are nearly the same, but we will use another register set, mmMP0_SMN_C2PMSG_101/102/103 to communicate with PSP
4: Skip programming some registers in guest KMD
As some registers are processed by new L1 security, amdgpu on VF will fail to program them, and don’t worry, these registers will be programmed on the SR-IOV host driver side.
5: Call RLC to program some registers in instead of MMIO
With new L1 policy, some registers can’t be programmed in SR-IOV VF amdgpu with MMIO. Fortunately, new RLC firmware will support to program them with specific program sequence, which are described in the patch commit message
Trigger Huang (9):
drm/amdgpu: init vega10 SR-IOV reg access mode drm/amdgpu: initialize PSP before IH under SR-IOV drm/amdgpu: Add new PSP cmd GFX_CMD_ID_PROG_REG drm/amdgpu: implement PSP cmd GFX_CMD_ID_PROG_REG drm/amdgpu: call psp to progrm ih cntl in SR-IOV drm/amdgpu: Support PSP VMR ring for Vega10 VF drm/amdgpu: Skip setting some regs under Vega10 VF drm/amdgpu: add basic func for RLC program reg drm/amdgpu: RLC to program regs for Vega10 SR-IOV
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 30 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 28 +++++ drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 11 +- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 43 +++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 12 ++ drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 114 ++++++++++--------- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 20 ++-- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 + drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 25 ++++- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 19 ++++ drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 8 ++ drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 131 ++++++++++++++++------ drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 14 ++- drivers/gpu/drm/amd/amdgpu/soc15.c | 52 ++++++--- drivers/gpu/drm/amd/amdgpu/soc15_common.h | 57 +++++++++- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 91 +++++++++++++-- 17 files changed, 514 insertions(+), 148 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx