System Firmware Loader for TI K3 family SoCs
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 13 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 13 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 00/13] System Firmware Loader for TI K3 family SoCs
Quoted 37 lines · dannenberg at ti.com
Hi TF,
thanks for chiming in. Comments inlined...Quoted 20 lines · Tien Fong
Quoted 5 lines · Simon Goldschmidt
Quoted 2 lines · Andreas Dannenberg
[...]
Quoted 12 lines
Quoted 12 lines
While I also have a working solution based on the existing FS loader
framework this has its own challenges, namely by its very nature
only
addressing a subset of our use cases (no eMMC/SD RAW boot support
for
example),Quoted 5 lines
IMO, it's actually not that hard to enhance RAW support, i think minimal changes are required. I have attached the patches about an example of loading RAW from QSPI that i have done locally last few week
ago.As your patches show, no it's not hard, it's more or less taking pieces
from the SPL loader framework and refactoring them into the FS loader,
creating a good and universal solution usable across SPL and U-Boot in
environments that are not tightly constrained in terms of memory.
Quoted 3 lines
What I was going after is finding a way to load from different media "pre-relocation" SPL (
board_init_f), with almost no memory available, where I have to agonize over every single KB available.
This is just a simple "loader", provide user flexibility of loading stuff in anywhere, from SPL to U-Boot. As long as DM is supported by the time running at "pre-relocation" SPL, then FS loader should be able to work.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
being heavier on resource usage (needing to use ENV to pass parameters),
Quoted 8 lines
Quoted 1 line
ENV is optional, you can use DTS.
Is it? I had to update the FS loader framework when I experimented with
it, please see attached patch. I had refactored it such that I can pass
in all relevant data via platform data for the intial boot mode I was going after, so that I can dynamically configure it on the fly from early SPLboard_init_f()based on boot media / boot mode, etc.
Yes, you can tie up loader with target HW node for destination loading. For example, tie up with FPGA manager node, loading bistream file from MMC to FPGA manager.
Here is an example, but i put the fs loader phandle under chosen node because most files and images are stored in the same storage.
http://git.denx.de/?p=u-boot/u-boot-socfpga.git;a=commit;h=0a42a132a4b846031df2c4a7d04692240ed34843
Quoted 18 lines
Quoted 18 lines
For example loading FPGA bitstream from QSPI RAW:
/* DTS */
/ {(quoted diff) +12
-0+ aliases { + spi0 = &qspi; + }; + + fs_loader0: fs-loader { + u-boot,dm-pre-reloc; + compatible = "u-boot,fs-loader"; + sfconfig = <0 0 100000000 3>; + }; +}; + +&fpga_mgr {
Quoted 8 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ u-boot,dm-pre-reloc; + firmware-loader = <&fs_loader0>; + altr,bitstream = "300000"; +};The above hard-codes and duplicates information that is already known to
U-Boot (CONFIG_SF_DEFAULT_*), and will do more of the same as this is being extended. How does one keep this consistent?
Current fs loader not support RAW loading yet, i'm not sure whether it should support it by adding more specific storage API(much more messy), or just fully support filesystem only with one generic filesystem abstract interface.
This example codes provide user opportunity to override the spi setting when running fs loader. CONFIG_SF_DEFAULT_* would be used by the drivers which are not running the fs loader.
Quoted 7 lines
And how does this scale to support like 5 different boot modes using a
single DTB? I guess one could populate 5 nodes, and then pick one based
on boot mode during SPL execution, by extending the probe function accordingly.
This is just a very simple fs loader. This is totally up to user how they want to scale it up, may be adding the function to populate the fs loader nodes, or loading the images based on boot storages ordering in DTS?
Quoted 24 lines
Quoted 11 lines
Quoted 6 lines
Quoted 6 lines
and not addressing the need to probe the boot peripheral.
You can add more different probing method in function called "
fs_loader_probe". Currentfs_loadersupportsblock(sdmmc, emmc, etc...)probing, and with
the patches attached support QSPI probing.Quoted 5 lines
Another idea come to mind, we can use
fs_loaderfor loading FIT boot
image into RAM, and boot from RAM with existing SPL loader framework,
but i'm not sure this implementation fit to your use case?Unfortunately for what I'm working on there is no space for this. It would be nice to be able to load our "System Firmware" alongside the next stage of U-Boot in a single FIT, and then just extact that firmware
image similar to whatCONFIG_SPL_FPGA_SUPPORTdoes inspl_fit.c. However I must load SYSFW and the U-Boot next stage as two steps (while bringing up DDR in-between....).
Quoted 7 lines
As I tried to explain in my earlier email to Simon, I almost see the minimally-intrusive extensions I did to the SPL loader framework via "spl: Make image loader infrastructure more universal" and the FS loader
framework to be elements that are orthogonal and can both exist. Maybe
FS loader can partially build upon the SPL loader foundation as well?
Yes, fs loader can be in anywhere, it can be part of SPL loader framework as well. It can be as complement to SPL loader also.
Thanks.
TF.
Quoted 98 lines
--
Andreas Dannenberg
Texas Instruments IncQuoted 90 lines
Quoted 11 lines
Quoted 11 lines
This particular framework works well for use cases requiring to load
firmware from FS-based media once DDR is up and U-Boot is in a more
"initialized" state but it is not a one-fits all solution for very
early use in SPLboard_init_f()accross different boot modes.Quoted 9 lines
And would it be an option to improve the loader (maybe dropping the
"fs"
from its name)? I think it's an "fs" loader because its idea has been
copied from Linux. I think in U-Boot, it's more common to have things
at
a raw offset instead of a file system. Just thinking...Current
fs_loaderonly support filesystem, and i agree that it made sense to remove the "fs" once it supports the RAW offset as well.Thanks.
Regards,
TFQuoted 62 lines
And the current state of that
fs_loaderis like it is because it fits
its single user (socfpga stratix 10), I think.Anyway, even if you do need yet another loader, would it make sense
to
create a common file instead of adding this in yourarch/mach?Regards,
SimonQuoted 48 lines
Andreas Dannenberg (10):
mmc:k3_arasan: Allow driver to probe without PDs specified
spl: Allow skipping clearing BSS during relocation
spl: Make image loader infrastructure more universal
arm: K3: Introduce System Firmware loader framework
armV7R: K3: am654: Allow using SPL BSS pre-relocation
armv7R: K3: am654: Use full malloc implementation in SPL
armV7R: K3: am654: Load SYSFW binary and config from boot media
configs:am65x_evm_r5: All sysfw to be loaded via MMC
configs:am65x_hs_evm_r5: All sysfw to be loaded via MMC
configs:am65x_hs_evm: Add Support for eMMC bootFaiz Abbas (2):
configs:am65x_evm: Add Support for eMMC boot
am65x: README: Add eMMC layout and flash instructionsLokesh Vutla (1):
armv7R: dts: k3: am654: Update mmc nodes for loading sysfwarch/arm/dts/k3-am654-r5-base-board.dts | 18 ++ arch/arm/lib/crt0.S | 3 + arch/arm/mach-k3/Kconfig | 40 +++ arch/arm/mach-k3/Makefile | 1 + arch/arm/mach-k3/am6_init.c | 34 ++-
arch/arm/mach-k3/include/mach/sysfw-loader.h| 12 + arch/arm/mach-k3/sysfw-loader.c | 263
+++++++++++++++++++
board/ti/am65x/Kconfig | 1 + board/ti/am65x/README | 52 ++++ common/spl/Kconfig | 13 + common/spl/spl_fit.c | 14 + common/spl/spl_mmc.c | 76 ++++-- configs/am65x_evm_a53_defconfig | 2 + configs/am65x_evm_r5_defconfig | 7 +- configs/am65x_hs_evm_a53_defconfig | 2 + configs/am65x_hs_evm_r5_defconfig | 7 +- drivers/mmc/k3_arsan_sdhci.c | 16 +- include/configs/am65x_evm.h | 30 ++- include/spl.h | 26 ++19 files changed, 577 insertions(+), 40 deletions(-)create mode 100644
arch/arm/mach-k3/include/mach/sysfw-loader.h
create mode 100644arch/arm/mach-k3/sysfw-loader.c