Skip to content

adding eventmode helper library

Anoob Joseph dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest39 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/39examples/l2fwd-event: create copy of l2fwdexamples/Makefile examples/l2fwd-event/Makefile examples/l2fwd-event/main.c +1 more+819 -00 replies
2/39examples/l2fwd-event: move macros to common headerexamples/l2fwd-event/l2fwd_common.h examples/l2fwd-event/main.c+27 -140 replies
3/39examples/l2fwd-event: move structures to common headerexamples/l2fwd-event/l2fwd_common.h examples/l2fwd-event/main.c+12 -100 replies
4/39examples/l2fwd-event: move global vars to common headerexamples/l2fwd-event/l2fwd_common.h examples/l2fwd-event/main.c+43 -243 replies
5/39examples/l2fwd-event: move dataplane code to new fileexamples/l2fwd-event/Makefile examples/l2fwd-event/l2fwd_worker.c examples/l2fwd-event/l2fwd_worker.h +2 more+244 -1880 replies
6/39examples/l2fwd-event: remove unused header includesexamples/l2fwd-event/l2fwd_worker.c+0 -120 replies
7/39examples/l2fwd-event: move drain buffers to new functionexamples/l2fwd-event/l2fwd_worker.c+20 -140 replies
8/39examples/l2fwd-event: optimize check for master coreexamples/l2fwd-event/l2fwd_worker.c+5 -20 replies
9/39examples/l2fwd-event: move periodic tasks to new funcexamples/l2fwd-event/l2fwd_worker.c examples/l2fwd-event/l2fwd_worker.h+52 -370 replies
10/39examples/l2fwd-event: do timer updates only on masterexamples/l2fwd-event/l2fwd_worker.c+13 -80 replies
11/39examples/l2fwd-event: move pkt send code to a new funcexamples/l2fwd-event/l2fwd_worker.c+14 -60 replies
12/39examples/l2fwd-event: use fprintf in usage printexamples/l2fwd-event/main.c+3 -10 replies
13/39examples/l2fwd-event: improvements to the usage printexamples/l2fwd-event/main.c+14 -90 replies
14/39eventdev: add files for eventmode helperlib/librte_eventdev/Makefile lib/librte_eventdev/meson.build lib/librte_eventdev/rte_eventmode_helper.c +2 more+33 -21 reply
15/39eventdev: add routines for logging eventmode helperconfig/common_base lib/librte_eal/common/eal_common_log.c lib/librte_eal/common/include/rte_log.h +1 more+32 -02 replies
16/39eventdev: add eventmode CL options frameworklib/librte_eventdev/rte_eventdev_version.map lib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h+181 -03 replies
17/39eventdev: allow application to set ethernet portmasklib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h+9 -00 replies
18/39eventdev: add framework for eventmode conflib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+21 -02 replies
19/39eventdev: add common initialize routine for eventmode devslib/librte_eventdev/rte_eventdev_version.map lib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h+77 -23 replies
20/39eventdev: add eventdevice init for eventmodelib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+146 -10 replies
21/39eventdev: add eventdev port-lcore linklib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h lib/librte_eventdev/rte_eventmode_helper_internal.h+46 -00 replies
22/39eventdev: add option to specify schedule mode for app stagelib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+30 -20 replies
23/39eventdev: add placeholder for ethdev initlib/librte_eventdev/rte_eventmode_helper.c+13 -00 replies
24/39eventdev: add Rx adapter init in eventmodelib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+150 -02 replies
25/39eventdev: add routine to validate conflib/librte_eventdev/rte_eventmode_helper.c+33 -02 replies
26/39eventdev: add default conf for event devs field in conflib/librte_eventdev/rte_eventmode_helper.c+67 -00 replies
27/39eventdev: add default conf for Rx adapter conflib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+131 -00 replies
28/39eventdev: add default conf for event port-lcore linklib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper_internal.h+113 -10 replies
29/39eventdev: add routines to display the eventmode conflib/librte_eventdev/Makefile lib/librte_eventdev/meson.build lib/librte_eventdev/rte_eventdev_version.map +3 more+178 -00 replies
30/39eventdev: add routine to access eventmode link infolib/librte_eventdev/rte_eventdev_version.map lib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h+105 -00 replies
31/39eventdev: add routine to access event queue for eth Txlib/librte_eventdev/rte_eventdev_version.map lib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h+75 -00 replies
32/39eventdev: add routine to launch eventmode workerslib/librte_eventdev/rte_eventdev_version.map lib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h +1 more+293 -05 replies
33/39eventdev: add Tx adapter supportlib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h lib/librte_eventdev/rte_eventmode_helper_internal.h +1 more+399 -131 reply
34/39eventdev: add support for internal portslib/librte_eventdev/rte_eventmode_helper.c lib/librte_eventdev/rte_eventmode_helper.h lib/librte_eventdev/rte_eventmode_helper_internal.h +1 more+192 -450 replies
35/39eventdev: display Tx adapter conflib/librte_eventdev/rte_eventmode_helper_prints.c+45 -10 replies
36/39examples/l2fwd-event: add eventmode for l2fwdexamples/l2fwd-event/Makefile examples/l2fwd-event/l2fwd_worker.c examples/l2fwd-event/main.c +1 more+360 -210 replies
37/39examples/l2fwd-event: add eventmode workerexamples/l2fwd-event/l2fwd_worker.c+163 -10 replies
38/39examples/l2fwd-event: add eventmode workerexamples/l2fwd-event/l2fwd_worker.c+218 -10 replies
39/39examples/l2fwd-event: add eventmode workerexamples/l2fwd-event/l2fwd_worker.c+199 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 00/39] adding eventmode helper library

This series adds support for eventmode helper library and l2fwd-event application.

First 13 patches creates a new l2fwd application (l2fwd-event). Minor code reorganization is done to faciliate seamless integration of eventmode.

Next 22 patches adds eventmode helper library. This library abstracts the configuration of event device & Rx-Tx event adapters. The library can be extended to allow users to control all the configuration exposed by adapters and eth device.

Last 4 patches implements eventmode in l2fwd-event application. With event device and adapters, fine tuned threads (based on dev capabilities) can be drafted to maximize performance. Eventmode library facilitates this and l2fwd-event demonstrates this usage.

With the introduction of eventmode helper library, any poll mode application can be converted to an eventmode application with simple steps, enabling multi-core scaling and dynamic load balancing to various example applications.

Usage:

     ./l2fwd-event -- <EAL args> -- <l2fwd args> -- --transfer-mode 1

The above command would invoke eventmode and with the default conf loaded, traffic on one port would be delivered to all enabled cores.

Planned features,
1. Eventmode helper library doesn't intialize ethdev. Since all applications already do this, eventmode helper would start from reconfiguring.
2. All features of eventdev and adapters can be exposed to the user using common CL arguments. The framework for achieving the same is already in place. It has to be extended to support more features.
3. Documentation is pending.

Created new app based on discussions,
http://patchwork.dpdk.org/cover/40884/
https://patches.dpdk.org/patch/40901/

Tested with nicvf eth PMD and event_octeontx event PMD on Marvell's CN83XX platform.

Anoob Joseph (39):
examples/l2fwd-event: create copy of l2fwd examples/l2fwd-event: move macros to common header examples/l2fwd-event: move structures to common header examples/l2fwd-event: move global vars to common header examples/l2fwd-event: move dataplane code to new file examples/l2fwd-event: remove unused header includes examples/l2fwd-event: move drain buffers to new function examples/l2fwd-event: optimize check for master core examples/l2fwd-event: move periodic tasks to new func examples/l2fwd-event: do timer updates only on master examples/l2fwd-event: move pkt send code to a new func examples/l2fwd-event: use fprintf in usage print examples/l2fwd-event: improvements to the usage print
eventdev: add files for eventmode helper
eventdev: add routines for logging eventmode helper
eventdev: add eventmode CL options framework
eventdev: allow application to set ethernet portmask
eventdev: add framework for eventmode conf
eventdev: add common initialize routine for eventmode devs
eventdev: add eventdevice init for eventmode
eventdev: add eventdev port-lcore link
eventdev: add option to specify schedule mode for app stage
eventdev: add placeholder for ethdev init
eventdev: add Rx adapter init in eventmode
eventdev: add routine to validate conf
eventdev: add default conf for event devs field in conf
eventdev: add default conf for Rx adapter conf
eventdev: add default conf for event port-lcore link
eventdev: add routines to display the eventmode conf
eventdev: add routine to access eventmode link info
eventdev: add routine to access event queue for eth Tx
eventdev: add routine to launch eventmode workers
eventdev: add Tx adapter support
eventdev: add support for internal ports
eventdev: display Tx adapter conf examples/l2fwd-event: add eventmode for l2fwd examples/l2fwd-event: add eventmode worker examples/l2fwd-event: add eventmode worker examples/l2fwd-event: add eventmode worker

 config/common_base                                 |    1 +
 examples/Makefile                                  |    1 +
 examples/l2fwd-event/Makefile                      |   57 +
 examples/l2fwd-event/l2fwd_common.h                |   63 +
 examples/l2fwd-event/l2fwd_worker.c                | 1121 +++++++++++++
 examples/l2fwd-event/l2fwd_worker.h                |   16 +
 examples/l2fwd-event/main.c                        |  585 +++++++
 examples/l2fwd-event/meson.build                   |   14 +
 lib/librte_eal/common/eal_common_log.c             |    1 +
 lib/librte_eal/common/include/rte_log.h            |    1 +
 lib/librte_eventdev/Makefile                       |    6 +-
 lib/librte_eventdev/meson.build                    |    3 +
 lib/librte_eventdev/rte_eventdev_version.map       |    8 +
 lib/librte_eventdev/rte_eventmode_helper.c         | 1678 ++++++++++++++++++++
 lib/librte_eventdev/rte_eventmode_helper.h         |  241 +++
 .../rte_eventmode_helper_internal.h                |  144 ++
 lib/librte_eventdev/rte_eventmode_helper_prints.c  |  223 +++
 17 files changed, 4161 insertions(+), 2 deletions(-)
 create mode 100644 examples/l2fwd-event/Makefile
 create mode 100644 examples/l2fwd-event/l2fwd_common.h
 create mode 100644 examples/l2fwd-event/l2fwd_worker.c
 create mode 100644 examples/l2fwd-event/l2fwd_worker.h
 create mode 100644 examples/l2fwd-event/main.c
 create mode 100644 examples/l2fwd-event/meson.build
 create mode 100644 lib/librte_eventdev/rte_eventmode_helper.c
 create mode 100644 lib/librte_eventdev/rte_eventmode_helper.h
 create mode 100644 lib/librte_eventdev/rte_eventmode_helper_internal.h
 create mode 100644 lib/librte_eventdev/rte_eventmode_helper_prints.c
Signature · 1 line
2.7.4