Skip to content

introduce LED block device activity trigger

Akinobu Mita linux-block linux-leds linux-nvme linux-scsi 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 11 repliesIn review
  2. v36 patches 7 repliesSuperseded
  3. v23 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block: umem: rename LED_* macros to MEMCTRL_LED_*drivers/block/umem.c drivers/block/umem.h+20 -200 replies
2/5scsi: mvsas: rename LED_* enums to SGPIO_LED_*drivers/scsi/mvsas/mv_94xx.c drivers/scsi/mvsas/mv_94xx.h+13 -130 replies
3/5scsi: nsp32: rename LED_* macros to EXT_PORT_LED_*drivers/scsi/nsp32.c drivers/scsi/nsp32.h+6 -50 replies
4/5block: introduce LED block device activity triggerDocumentation/ABI/testing/sysfs-class-led-trigger-blk block/genhd.c drivers/leds/trigger/Kconfig +4 more+349 -010 replies
5/5scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspenddrivers/scsi/sd.c+23 -171 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchPavel MachekHannes Reinecke
1/5A-b
2/5A-b R-b
3/5A-b R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] introduce LED block device activity trigger

This work is inspired by the report on linux-nvme mailing list.

disk-activity trigger not working for nvme disk:
http://lists.infradead.org/pipermail/linux-nvme/2019-July/025253.html

This LED block device activity trigger works with any block devices.

* v4
- Squash patch 'add interface to stop and restart polling disk stats' into the ledtrig-blk introduction patch
- Rename 'led' to 'led_trig' in struct ledtrig_blk

* v3
- Avoid the name collision with LED_OFF and LED_ON
- Add ABI documentation
- Add more detail to Kconfig help text

* v2
- Remove "move declaration of led_stop_software_blink() to linux/leds.h" patch
- Move the trigger implementation to drivers/leds/trigger
- s/blk_ledtrig/ledtrig_blk/
- Add CONFIG_LEDS_TRIGGER_BLOCK
- Fix wrong bitops usages
- Add interface to stop and restart polling disk stats
- Stop polling disk stats for scsi disk during runtime suspend

Akinobu Mita (5):
block: umem: rename LED_* macros to MEMCTRL_LED_*
scsi: mvsas: rename LED_* enums to SGPIO_LED_*
scsi: nsp32: rename LED_* macros to EXT_PORT_LED_*
block: introduce LED block device activity trigger
scsi: sd: stop polling disk stats by ledtrig-blk during runtime
suspend

 .../ABI/testing/sysfs-class-led-trigger-blk        |  37 +++
 block/genhd.c                                      |   2 +
 drivers/block/umem.c                               |  20 +-
 drivers/block/umem.h                               |  20 +-
 drivers/leds/trigger/Kconfig                       |   9 +
 drivers/leds/trigger/Makefile                      |   1 +
 drivers/leds/trigger/ledtrig-blk.c                 | 259 +++++++++++++++++++++
 drivers/scsi/mvsas/mv_94xx.c                       |   2 +-
 drivers/scsi/mvsas/mv_94xx.h                       |  24 +-
 drivers/scsi/nsp32.c                               |   7 +-
 drivers/scsi/nsp32.h                               |   4 +-
 drivers/scsi/sd.c                                  |  40 ++--
 include/linux/genhd.h                              |   3 +
 include/linux/leds.h                               |  38 +++
 14 files changed, 411 insertions(+), 55 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-blk
 create mode 100644 drivers/leds/trigger/ledtrig-blk.c
Cc Frank Steiner <fsteiner-mail1 at bio.ifi.lmu.de>
Cc Jacek Anaszewski <jacek.anaszewski at gmail.com>
Cc Pavel Machek <pavel at ucw.cz>
Cc Dan Murphy <dmurphy at ti.com>
Cc Jens Axboe <axboe at kernel.dk>
Cc "James E.J. Bottomley" <jejb at linux.ibm.com>
Cc "Martin K. Petersen" <martin.petersen at oracle.com>
Cc GOTO Masanori <gotom at debian.or.jp>
Cc YOKOTA Hiroshi <yokota at netlab.is.tsukuba.ac.jp>
Cc Hannes Reinecke <hare at suse.com>
Signature · 1 line
2.7.4