Skip to content

Allow OHCI drivers to override hub control operations

Laurent Pinchart linux-arm-kernel 1 version New

Get series with b4
b4 am 1563131.ShpASGpY9t@avalon

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH/RFC 0/3] Allow OHCI drivers to override hub control operations

Hi Alan,

Quoted 13 lines · On Tuesday 15 April 2014 14:05:14 Alan Stern wrote:
Quoted 8 lines · Laurent Pinchart
Quoted 3 lines

I'm open to the idea of exporting the hub functions. In the end, it doesn't make all that much difference (it would save a little object code).

I would have agreed to keep the code as it is today if you had thought that exporting the hub functions was a really bad idea, but as you're open to it, and as it removes a bit of code without much of a drawback, I think it makes sense to perform that optimization.

Agreed. We aren't really _encouraging_ people to do this, because it still takes some manual work to override the default operation.

Quoted 6 lines
Quoted 2 lines

By the way, as a second step, do you think it would make sense to handle the vbus regulators directly in ohci_hub_control() ?

I don't see any good way of doing this generically. Since it is currently needed only for PXA27x, we don't know what other architectures will require in the future.

Fine with me, let's revisit this later if needed then.

Signature · 3 lines
Regards,

Laurent Pinchart