Skip to content

mm/memcontrol: recharge mlocked pages

Konstantin Khlebnikov cgroups linux-mm lkml 1 version In review

Get series with b4
b4 am 156760509382.6560.17364256340940314860.stgit@buzz

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mm/memcontrol: move locking page out of mem_cgroup_move_accountmm/memcontrol.c+31 -330 replies
2/7mm/memcontrol: add mem_cgroup_rechargeinclude/linux/memcontrol.h mm/memcontrol.c+49 -00 replies
3/7mm/mlock: add vma argument for mlock_vma_page()mm/gup.c mm/huge_memory.c mm/internal.h +4 more+9 -90 replies
4/7mm/mlock: recharge memory accounting to first mlock userDocumentation/admin-guide/cgroup-v1/memory.rst mm/mlock.c+13 -10 replies
5/7mm/mlock: recharge memory accounting to second mlock user at munlockinclude/linux/rmap.h mm/gup.c mm/huge_memory.c +5 more+26 -190 replies
6/7mm/vmscan: allow changing page memory cgroup during reclaimmm/vmscan.c+8 -60 replies
7/7mm/mlock: recharge mlocked pages at culling by vmscanmm/vmscan.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/7] mm/memcontrol: recharge mlocked pages

Currently mlock keeps pages in cgroups where they were accounted. This way one container could affect another if they share file cache. Typical case is writing (downloading) file in one container and then locking in another. After that first container cannot get rid of cache. Also removed cgroup stays pinned by these mlocked pages.

This patchset implements recharging pages to cgroup of mlock user.

There are three cases:
* recharging at first mlock
* recharging at munlock to any remaining mlock
* recharging at 'culling' in reclaimer to any existing mlock

To keep things simple recharging ignores memory limit. After that memory usage temporary could be higher than limit but cgroup will reclaim memory later or trigger oom, which is valid outcome when somebody mlock too much.

---

Konstantin Khlebnikov (7):
mm/memcontrol: move locking page out of mem_cgroup_move_account mm/memcontrol: add mem_cgroup_recharge
mm/mlock: add vma argument for mlock_vma_page() mm/mlock: recharge memory accounting to first mlock user mm/mlock: recharge memory accounting to second mlock user at munlock mm/vmscan: allow changing page memory cgroup during reclaim mm/mlock: recharge mlocked pages at culling by vmscan

 Documentation/admin-guide/cgroup-v1/memory.rst |    5 +
 include/linux/memcontrol.h                     |    9 ++
 include/linux/rmap.h                           |    3 -
 mm/gup.c                                       |    2 
 mm/huge_memory.c                               |    4 -
 mm/internal.h                                  |    6 +
 mm/ksm.c                                       |    2 
 mm/memcontrol.c                                |  104 ++++++++++++++++--------
 mm/migrate.c                                   |    2 
 mm/mlock.c                                     |   14 +++
 mm/rmap.c                                      |    5 +
 mm/vmscan.c                                    |   17 ++--
 12 files changed, 121 insertions(+), 52 deletions(-)

--
Signature