leds: fix /sys/class/leds/<led>/trigger and add new api
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/triggerdrivers/ drivers/ drivers/ +1 more | +79 | 5 replies | |
| 2/5 | leds: make sure leds_class is initialized before triggers are registereddrivers/ | +1 | 1 reply | |
| 3/5 | driver core: class: add function to create /sys/class/<class>/foo directorydrivers/ include/ | +10 | 3 replies | |
| 4/5 | leds: add /sys/class/triggers/ that contains trigger sub-directoriesDocumentation/ drivers/ drivers/ +2 more | +62 | 1 reply | |
| 5/5 | leds: add /sys/class/leds/<led>/current-triggerDocumentation/ drivers/ drivers/ +1 more | +59 | 1 reply |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Pavel Machek |
|---|---|
| 1/5 | A-b |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] leds: fix /sys/class/leds/<led>/trigger and add new api
Reading /sys/class/leds/<led>/trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute.
Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all available LED triggers and which trigger is currently activated.
The first patch in this series converts /sys/class/leds/<led>/trigger to bin attribute and removes the PAGE_SIZE limitation.
The rest of series provides a new /sys/class/triggers/ directory and /sys/class/leds/<led>/current-trigger. The new api follows the "one value per file" rule of sysfs.
Akinobu Mita (5):
leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger
leds: make sure leds_class is initialized before triggers are
registered
driver core: class: add function to create /sys/class/<class>/foo
directory
leds: add /sys/class/triggers/ that contains trigger sub-directories
leds: add /sys/class/leds/<led>/current-trigger
Documentation/ABI/testing/sysfs-class-led | 22 +++++ drivers/base/class.c | 7 ++ drivers/leds/led-class.c | 49 +++++++++-- drivers/leds/led-triggers.c | 139 +++++++++++++++++++++++++----- drivers/leds/leds.h | 12 +++ include/linux/device.h | 3 + include/linux/leds.h | 6 +- 7 files changed, 207 insertions(+), 31 deletions(-)
Signature · 1 line
2.7.4