Skip to content

fix and optimize barriers usage with some PMDs

Gavin Hu dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 9 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net/i40e: use relaxed and remove duplicate barrierdrivers/net/i40e/i40e_rxtx.c+3 -94 replies
2/5net/ice: use relaxed and remove duplicate barrierdrivers/net/ice/ice_rxtx.c+0 -61 reply
3/5net/bnxt: remove duplicate barrierdrivers/net/bnxt/bnxt_hwrm.c+0 -31 reply
4/5net/bnxt: replace with cio barrier for doorbell respdrivers/net/bnxt/bnxt_hwrm.c+1 -11 reply
5/5net/bnxt: enforce io barrier for doorbell commanddrivers/net/bnxt/bnxt_hwrm.c+6 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSteve CapperRuifeng WangPhil YangQi ZhangAjit Khaparde
1/5A-b
2/5A-b
3/5R-b R-b R-b A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/5] fix and optimize barriers usage with some PMDs

DPDK has well-defined barriers, such as CIO barriers and IO barriers.

X86, as a strong ordering model, implements the barriers as compiler barriers, but on aarch64, as a weak memory ordering model, has fine grained barriers. Using correct while as relaxed as possible barriers makes a perf difference.

Upon investigation on a batch of PMDs and it was found that the barriers are not always used correctly or relaxedly enough.

This series of patches is to optimize the barrier usage with some selected PMDs and aim at best performance on all arches/platforms.

More PMDs may come next to this series but it takes time.

Gavin Hu (5):
net/i40e: use relaxed and remove duplicate barrier net/ice: use relaxed and remove duplicate barrier net/bnxt: remove duplicate barrier net/bnxt: replace with cio barrier for doorbell resp net/bnxt: enforce io barrier for doorbell command

 drivers/net/bnxt/bnxt_hwrm.c | 11 +++++++----
 drivers/net/i40e/i40e_rxtx.c | 12 +++---------
 drivers/net/ice/ice_rxtx.c   |  6 ------
 3 files changed, 10 insertions(+), 19 deletions(-)
Signature · 1 line
2.7.4