Fix memory instability on ROCK64
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/2] Fix memory instability on ROCK64
Quoted 22 lines · Simon South
These two patches fix small issues with the Rockchip RK3328 SDRAM driver that prevented my PINE64 ROCK64 from booting and running normally using U-Boot's TPL [1].
The first patch updates the
phy_dll_bypass_set()function to use the correct units for its DDR-frequency parameter, which is already specified in MHz and does not need converting. This issue caused the DRAM controller to be misconfigured for all but the lowest memory speeds.The second patch fixes an apparent typo in
phy_cfg()that caused the DRAM controller's deskew registers to be loaded with incorrect values:
Instead of copying from the second 44-element portion of the skew-value array the driver instead re-used a portion of the first. This also produced instability.With both these patches applied my ROCK64 boots and runs normally using the U-Boot TPL and a memory frequency of either 800 or 933 MHz:
In both cases the "mtest" memory-test command runs indefinitely without error, and I can boot into NetBSD successfully without the kernel hanging or panicking.
Quoted 9 lines
[1] https://lists.denx.de/pipermail/u-boot/2019-September/384076.html
Simon South (2):
ram: rk3328: Use correct frequency units in function
ram: rk3328: Fix loading of skew valuesdrivers/ram/rockchip/sdram_rk3328.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Your corrections also have helped OpenBSD/arm64 boot using u-boot TPL on Rock64. Here is one test report result:
https://marc.info/?l=openbsd-arm&m=157041723301520&w=2
Thank you for tracking down the problems.
-Kurt