Skip to content

selftests: Fixes for 32bit arch

Masami Hiramatsu linux-kselftest lkml 3 versions – In review

Get series with b4
b4 am 157180665007.17298.907392422924029261.stgit@devnote2

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyIn review
  2. v25 patches 3 repliesSuperseded
  3. v15 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5selftests: proc: Make va_max 1MBtools/testing/selftests/proc/proc-self-map-files-002.c+5 -10 replies
2/5selftests: vm: Build/Run 64bit tests only on 64bit archtools/testing/selftests/vm/Makefile tools/testing/selftests/vm/run_vmtests+15 -00 replies
3/5selftests: net: Use size_t and ssize_t for counting file sizetools/testing/selftests/net/tcp_mmap.c+4 -40 replies
4/5selftests: net: Fix printf format warnings on armtools/testing/selftests/net/so_txtime.c tools/testing/selftests/net/udpgso.c tools/testing/selftests/net/udpgso_bench_tx.c+6 -40 replies
5/5selftests: sync: Fix cast warnings on armtools/testing/selftests/sync/sync.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch

Hi,

Here are the 3rd version of kselftest fixes some on 32bit arch (e.g. arm)

In this version, I updated [1/5] to make va_max 1MB unconditionally according to Alexey's comment.

When I built the ksefltest on arm, I hit some 32bit related warnings. Here are the patches to fix those issues.

- [1/5] va_max was set 2^32 even on 32bit arch. This can make

        va_max == 0 and always fail. Make it 1GB unconditionally.

- [2/5] Some VM tests requires 64bit user space, which should not run on 32bit arch.
- [3/5] For counting the size of large file, we should use size_t instead of unsinged long.
- [4/5] Gcc warns printf format for size_t and int64_t on 32bit arch. Use %llu and cast it.
- [5/5] Gcc warns __u64 and pointer type castings. It should once translated to unsigned long.

Thank you,

---

Masami Hiramatsu (5):
selftests: proc: Make va_max 1MB
selftests: vm: Build/Run 64bit tests only on 64bit arch
selftests: net: Use size_t and ssize_t for counting file size
selftests: net: Fix printf format warnings on arm
selftests: sync: Fix cast warnings on arm

 tools/testing/selftests/net/so_txtime.c            |    4 ++--
 tools/testing/selftests/net/tcp_mmap.c             |    8 ++++----
 tools/testing/selftests/net/udpgso.c               |    3 ++-
 tools/testing/selftests/net/udpgso_bench_tx.c      |    3 ++-
 .../selftests/proc/proc-self-map-files-002.c       |    6 +++++-
 tools/testing/selftests/sync/sync.c                |    6 +++---
 tools/testing/selftests/vm/Makefile                |    5 +++++
 tools/testing/selftests/vm/run_vmtests             |   10 ++++++++++
 8 files changed, 33 insertions(+), 12 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>