Skip to content

net: bcmgenet: restore internal EPHY support

Doug Berger lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: bcmgenet: don't set phydev->link from MACdrivers/net/ethernet/broadcom/genet/bcmgenet.c+1 -31 reply
2/4net: phy: bcm7xxx: define soft_reset for 40nm EPHYdrivers/net/phy/bcm7xxx.c+1 -01 reply
3/4net: bcmgenet: soft reset 40nm EPHYs before MAC initdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h drivers/net/ethernet/broadcom/genet/bcmmii.c+69 -732 replies
4/4net: bcmgenet: reset 40nm EPHY on energy detectdrivers/net/ethernet/broadcom/genet/bcmgenet.c+8 -11 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/4] net: bcmgenet: restore internal EPHY support

I managed to get my hands on an old BCM97435SVMB board to do some testing with the latest kernel and uncovered a number of things that managed to get broken over the years (some by me ;).

This commit set attempts to correct the errors I observed in my testing.

The first commit applies to all internal PHYs to restore proper reporting of link status when a link comes up.

The second commit restores the soft reset to the initialization of the older internal EPHYs used by 40nm Set-Top Box devices.

The third corrects a bug I introduced when removing excessive soft resets by altering the initialization sequence in a way that keeps the GENETv3 MAC interface happy.

Finally, I observed a number of issues when manually configuring the network interface of the older EPHYs that appear to be resolved by the fourth commit.

Doug Berger (4):
net: bcmgenet: don't set phydev->link from MAC
net: phy: bcm7xxx: define soft_reset for 40nm EPHY
net: bcmgenet: soft reset 40nm EPHYs before MAC init
net: bcmgenet: reset 40nm EPHY on energy detect

 drivers/net/ethernet/broadcom/genet/bcmgenet.c |  41 +++++----
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 +-
 drivers/net/ethernet/broadcom/genet/bcmmii.c   | 112 +++++++++++--------------
 drivers/net/phy/bcm7xxx.c                      |   1 +
 4 files changed, 79 insertions(+), 77 deletions(-)
Signature · 1 line
2.7.4