Skip to content

RFC Redefine interconnect provider DT nodes for SDM845

David Dai linux-arm-msm linux-devicetree linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dt-bindings: interconnect: Update Qualcomm SDM845 DT bindingsDocumentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml+153 -240 replies
2/4arm64: dts: sdm845: Redefine interconnect provider DT nodesarch/arm64/boot/dts/qcom/sdm845.dtsi+57 -30 replies
3/4interconnect: qcom: Refactor icc rpmh supportdrivers/interconnect/qcom/Kconfig drivers/interconnect/qcom/Makefile drivers/interconnect/qcom/bcm-voter.c +3 more+699 -02 replies
4/4interconnect: qcom: sdm845: Split qnodes into their respective NoCsdrivers/interconnect/qcom/sdm845.c+206 -5211 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] Redefine interconnect provider DT nodes for SDM845

While there are no current consumers of the SDM845 interconnect device in devicetree, take this opportunity to redefine the interconnect device nodes as the previous definitions of using a single child node under the apps_rsc device did not accurately capture the description of the hardware. The Network-On-Chip (NoC) interconnect devices should be represented in a manner akin to QCS404 platforms[1] where there is a separation of NoC devices and its RPM/RPMh counterparts.

The bcm-voter devices are representing the RPMh devices that the interconnect providers need to communicate with and there can be more than one instance of the Bus Clock Manager (BCM) which can live under different instances of Resource State Coordinators (RSC). There are display use cases where consumers may need to target a different bcm-voter (Some display specific RSC) than the default, and there needs to be a way to represent this connection in devicetree.

This patches series extends the original discussion involving the SDM845 interconnect bindings[2] by adding accompanying driver implementations using the split NoC devices. The first patch also updates existing sdm845 binding documentation to DT schema format using json-schema.

[1]: https://lkml.org/lkml/2019/6/13/143
[2]: https://lkml.org/lkml/2019/7/19/1063

David Dai (4):
dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings
arm64: dts: sdm845: Redefine interconnect provider DT nodes
interconnect: qcom: Refactor icc rpmh support
interconnect: qcom: sdm845: Split qnodes into their respective NoCs

 .../bindings/interconnect/qcom,bcm-voter.yaml      |  45 ++
 .../bindings/interconnect/qcom,sdm845.txt          |  24 -
 .../bindings/interconnect/qcom,sdm845.yaml         | 108 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               |  60 +-
 drivers/interconnect/qcom/Kconfig                  |   8 +
 drivers/interconnect/qcom/Makefile                 |   4 +
 drivers/interconnect/qcom/bcm-voter.c              | 355 ++++++++++
 drivers/interconnect/qcom/bcm-voter.h              |  28 +
 drivers/interconnect/qcom/icc-rpmh.c               | 154 +++++
 drivers/interconnect/qcom/icc-rpmh.h               | 150 +++++
 drivers/interconnect/qcom/sdm845.c                 | 727 ++++++---------------
 11 files changed, 1115 insertions(+), 548 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
 delete mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.txt
 create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845.yaml
 create mode 100644 drivers/interconnect/qcom/bcm-voter.c
 create mode 100644 drivers/interconnect/qcom/bcm-voter.h
 create mode 100644 drivers/interconnect/qcom/icc-rpmh.c
 create mode 100644 drivers/interconnect/qcom/icc-rpmh.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project