Skip to content

perf probe: Fixes bugs in show-lines and show vars etc.

Masami Hiramatsu lkml 1 version Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am 157241935028.32002.10228194508152968737.stgit@devnote2

Versions newest first

  1. v1 Latest4 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4perf probe: Skip end-of-sequence and non statement linestools/perf/util/dwarf-aux.c+7 -03 replies
2/4perf probe: Filter out instances except for inlined subroutine and subprogramtools/perf/util/dwarf-aux.c+13 -61 reply
3/4perf probe: Fix to show calling lines of inlined functionstools/perf/util/dwarf-aux.c+9 -11 reply
4/4perf probe: Skip overlapped location on searching variablestools/perf/util/probe-finder.c+20 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [BUGFIX PATCH 0/4] perf probe: Fixes bugs in show-lines and show vars etc.

Hi Arnaldo,

Here are some more patches for fixing bugs which I found while testing it.

- [1/4]: I found that the debuginfo had precise line information but including non-statement and end-of-sequence entries. Those must be ignored because not represent target line.

- [2/4]: I also found that there is GNU_call_site DIEs in debuginfo, which represents the location which calls another function. Since it is not an instance of inlined function, it must be ignored while searching instances of inlined function.

- [3/4]: However, while listing up the available lines, we also need to show the lines calling another function. So if call_line and call_file attribute are same as line information, it shows that line as available.

- [4/4]: It's a small fix to skip overlapped location while showing available variables.

Thank you,

---

Masami Hiramatsu (4):
perf probe: Skip end-of-sequence and non statement lines
perf probe: Filter out instances except for inlined subroutine and subprogram perf probe: Fix to show calling lines of inlined functions
perf probe: Skip overlapped location on searching variables

 tools/perf/util/dwarf-aux.c    |   36 +++++++++++++++++++++++++++++-------
 tools/perf/util/probe-finder.c |   20 ++++++++++++++++++++
 2 files changed, 49 insertions(+), 7 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>