Skip to content

perf/probe: Support multiprobe and immediates with fixes

Masami Hiramatsu lkml 3 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am 157406469983.24476.13195800716161845227.stgit@devnote2

Versions newest first · linked by author and title

  1. v3 Latest7 patches 7 repliesApplied
  2. v24 patches 7 repliesSuperseded
  3. v15 patches 8 repliesApplied

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7perf probe: Show correct statement line number by perf probe -ltools/perf/util/dwarf-aux.c+58 -41 reply
2/7perf probe: Verify given line is a representive linetools/perf/util/probe-finder.c+36 -01 reply
3/7perf probe: Do not show non representive lines by perf-probe -Ltools/perf/util/probe-finder.c+7 -01 reply
4/7perf probe: Generate event name with line numbertools/perf/util/probe-event.c+8 -01 reply
5/7perf probe: Support multiprobe eventtools/perf/util/probe-event.c tools/perf/util/probe-file.c tools/perf/util/probe-file.h+15 -20 replies
6/7perf probe: Support DW_AT_const_value constant valuetools/perf/util/probe-file.c tools/perf/util/probe-file.h tools/perf/util/probe-finder.c+19 -00 replies
7/7perf probe: Trace a magic number if variable is not foundtools/perf/util/probe-event.c tools/perf/util/probe-event.h tools/perf/util/probe-finder.c +1 more+63 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes

Hi Arnaldo,

This is the 3rd version of the multiprobe support on perf probe including some fixes about "representive lines"

The previous thread is here:

https://lkml.kernel.org/r/157314406866.4063.16995747442215702109.stgit@devnote2

On the previous thread, we discussed some issues about incorrect line information shown by perf probe. I finally fixed those by introducing an idea of "representive line" -- a line which has a unique address (no other lines shares the same address) or a line which has the least line number among lines sharing same address. Now perf probe only shows such representive lines can be probed([1/7][3/7]), and if user tries to probe other non representive lines, it shows which line user should probe ([2/7]). The rest of patches in the series are same as v2 (except for [4/7], example output is updated)

This can be applied on top of perf/core.

Thank you,

---

Masami Hiramatsu (7):
perf probe: Show correct statement line number by perf probe -l perf probe: Verify given line is a representive line perf probe: Do not show non representive lines by perf-probe -L perf probe: Generate event name with line number perf probe: Support multiprobe event
perf probe: Support DW_AT_const_value constant value perf probe: Trace a magic number if variable is not found

 tools/perf/util/dwarf-aux.c    |   62 ++++++++++++++++++++-
 tools/perf/util/probe-event.c  |   19 ++++++-
 tools/perf/util/probe-event.h  |    3 +
 tools/perf/util/probe-file.c   |   14 +++++
 tools/perf/util/probe-file.h   |    2 +
 tools/perf/util/probe-finder.c |  116 +++++++++++++++++++++++++++++++++++++++-
 tools/perf/util/probe-finder.h |    1 
 7 files changed, 206 insertions(+), 11 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>