Skip to content

net: bcmgenet: restore internal EPHY support (part 2)

Doug Berger lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: bcmgenet: use RGMII loopback for MAC resetdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmmii.c+33 -24 replies
2/3Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init"drivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h drivers/net/ethernet/broadcom/genet/bcmmii.c+73 -691 reply
3/3net: bcmgenet: reapply manual settings to the PHYdrivers/net/ethernet/broadcom/genet/bcmgenet.c+4 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] net: bcmgenet: restore internal EPHY support (part 2)

This is a follow up to my previous submission (see [1]).

The first commit provides what is intended to be a complete solution for the issues that can result from insufficient clocking of the MAC during reset of its state machines. It should be backported to the stable releases.

It is intended to replace the partial solution of commit 1f515486275a ("net: bcmgenet: soft reset 40nm EPHYs before MAC init") which is reverted by the second commit of this series and should not be back- ported as noted in [2].

The third commit corrects a timing hazard with a polled PHY that can occur when the MAC resumes and also when a v3 internal EPHY is reset by the change in commit 25382b991d25 ("net: bcmgenet: reset 40nm EPHY on energy detect"). It is expected that commit 25382b991d25 be back- ported to stable first before backporting this commit.

[1] https://lkml.org/lkml/2019/10/16/1706
[2] https://lkml.org/lkml/2019/10/31/749

Doug Berger (3):
net: bcmgenet: use RGMII loopback for MAC reset Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init"
net: bcmgenet: reapply manual settings to the PHY

 drivers/net/ethernet/broadcom/genet/bcmgenet.c |  35 +++---
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 +-
 drivers/net/ethernet/broadcom/genet/bcmmii.c   | 145 ++++++++++++++++---------
 3 files changed, 110 insertions(+), 72 deletions(-)
Signature · 1 line
2.7.4