Skip to content

Support wakeup capable GPIOs

Lina Iyer linux-arm-msm linux-devicetree linux-gpio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 21 repliesIn review

Changes in v1 from the cover letter

- Address review comments
- Add Reviewed-by tags
- Drop SPI config patches
- Rebase on top of Rajendra's PDC changes [6]

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12irqdomain: add bus token DOMAIN_BUS_WAKEUPinclude/linux/irqdomain.h+1 -01 reply
2/12drivers: irqchip: qcom-pdc: update max PDC interruptsdrivers/irqchip/qcom-pdc.c+2 -21 reply
3/12drivers: irqchip: pdc: Do not toggle IRQ_ENABLE during mask/unmaskdrivers/irqchip/qcom-pdc.c+14 -21 reply
4/12drivers: irqchip: add PDC irqdomain for wakeup capable GPIOsdrivers/irqchip/qcom-pdc.c include/linux/soc/qcom/irq.h+116 -91 reply
5/12of: irq: document properties for wakeup interrupt parentDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt+12 -01 reply
6/12genirq: Introduce irq_chip_get/set_parent_state callsinclude/linux/irq.h kernel/irq/chip.c+50 -01 reply
7/12drivers: irqchip: pdc: Add irqchip set/get state callsdrivers/irqchip/qcom-pdc.c+23 -01 reply
8/12drivers: pinctrl: msm: setup GPIO chip in hierarchydrivers/pinctrl/qcom/pinctrl-msm.c drivers/pinctrl/qcom/pinctrl-msm.h include/linux/soc/qcom/irq.h+142 -07 replies
9/12drivers: pinctrl: sdm845: add PDC wakeup interrupt map for GPIOsdrivers/pinctrl/qcom/pinctrl-sdm845.c+22 -11 reply
10/12arm64: dts: qcom: add PDC interrupt controller for SDM845arch/arm64/boot/dts/qcom/sdm845.dtsi+9 -01 reply
11/12arm64: dts: qcom: setup PDC as the wakeup parent for TLMM on SDM845arch/arm64/boot/dts/qcom/sdm845.dtsi+1 -01 reply
12/12arm64: defconfig: enable PDC interrupt controller for Qualcomm SDM845arch/arm64/configs/defconfig+1 -01 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijRob HerringStephen Boyd
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b R-b R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] Support wakeup capable GPIOs

Hi all,

Thanks for all the reviews.

Here is the next spin of the wakeup capable GPIO support. In order to facilitate basic support available in the kernel, I have dropped the SPI register configuration. The feature was added when this series was restarted based on new hierarchy support in gpiolib. But, the SPI configuration can be done in the firmware. This would avoid a whole lot of code in linux that serve little to no purpose. Users of GPIO never have the need to change the trigger type (level edge and vice-versa) and the basic configuration can be set in the firmware before boot.

Changes in v1:
- Address review comments
- Add Reviewed-by tags
- Drop SPI config patches
- Rebase on top of Rajendra's PDC changes [6]

Changes in RFC v2[5]:
- Address review comments #3, #4, #6, #7, #8, #9, #10
- Rebased on top of linux-next GPIO latest patches [1],[3],[4]
- Increase PDC max irqs in #2 (avoid merge conflicts with downstream)
- Add Reviewed-by #5

Please consider reviewing these patches.

Thanks,
Lina

[1].
https://lore.kernel.org/linux-gpio/[email protected]/
[2].
https://lkml.org/lkml/2019/5/7/1173
[3].
https://lore.kernel.org/r/[email protected]
[4].
https://lore.kernel.org/r/[email protected]
[5].
https://lore.kernel.org/linux-gpio/[email protected]/t/
[6].
https://lore.kernel.org/linux-arm-msm/[email protected]/

Lina Iyer (10):
irqdomain: add bus token DOMAIN_BUS_WAKEUP
drivers: irqchip: qcom-pdc: update max PDC interrupts
drivers: irqchip: pdc: Do not toggle IRQ_ENABLE during mask/unmask
drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs
of: irq: document properties for wakeup interrupt parent
drivers: pinctrl: msm: setup GPIO chip in hierarchy
drivers: pinctrl: sdm845: add PDC wakeup interrupt map for GPIOs
arm64: dts: qcom: add PDC interrupt controller for SDM845
arm64: dts: qcom: setup PDC as the wakeup parent for TLMM on SDM845
arm64: defconfig: enable PDC interrupt controller for Qualcomm SDM845

Maulik Shah (2):
genirq: Introduce irq_chip_get/set_parent_state calls
drivers: irqchip: pdc: Add irqchip set/get state calls

 .../bindings/interrupt-controller/interrupts.txt   |  12 ++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               |  10 ++
 arch/arm64/configs/defconfig                       |   1 +
 drivers/irqchip/qcom-pdc.c                         | 147 +++++++++++++++++++--
 drivers/pinctrl/qcom/pinctrl-msm.c                 | 113 ++++++++++++++++
 drivers/pinctrl/qcom/pinctrl-msm.h                 |  16 +++
 drivers/pinctrl/qcom/pinctrl-sdm845.c              |  23 +++-
 include/linux/irq.h                                |   6 +
 include/linux/irqdomain.h                          |   1 +
 include/linux/soc/qcom/irq.h                       |  34 +++++
 kernel/irq/chip.c                                  |  44 ++++++
 11 files changed, 393 insertions(+), 14 deletions(-)
 create mode 100644 include/linux/soc/qcom/irq.h

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project