Skip to content

add header file for kelvin to/from Celsius conversion helpers

Akinobu Mita linux-hwmon linux-iio linux-nvme linux-pm linux-wireless lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 2 repliesIn review 11 of 12 applied
  2. v312 patches 10 repliesSuperseded
  3. v28 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches17 repliesSuperseded

Patches in v4 11 of 12 applied

#Subject and filesSizeRepliesApplied
1/12add helpers for kelvin to/from Celsius conversioninclude/linux/units.h+84 -00 repliesApplied
2/12ACPI: thermal: switch to use <linux/units.h> helpersdrivers/acpi/thermal.c+18 -160 repliesApplied
3/12platform/x86: asus-wmi: switch to use <linux/units.h> helpersdrivers/platform/x86/asus-wmi.c+3 -40 repliesApplied
4/12platform/x86: intel_menlow: switch to use <linux/units.h> helpersdrivers/platform/x86/intel_menlow.c+6 -30 repliesApplied
5/12thermal: int340x: switch to use <linux/units.h> helpersdrivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c+4 -30 repliesApplied
6/12thermal: intel_pch: switch to use <linux/units.h> helpersdrivers/thermal/intel/intel_pch_thermal.c+2 -10 repliesApplied
7/12nvme: hwmon: switch to use <linux/units.h> helpersdrivers/nvme/host/hwmon.c+5 -80 repliesApplied
8/12thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h>include/linux/thermal.h+0 -110 repliesApplied
9/12iwlegacy: use <linux/units.h> helpersdrivers/net/wireless/intel/iwlegacy/4965-mac.c drivers/net/wireless/intel/iwlegacy/4965.c drivers/net/wireless/intel/iwlegacy/common.h+8 -90 replies
10/12iwlwifi: use <linux/units.h> helpersdrivers/net/wireless/intel/iwlwifi/dvm/dev.h drivers/net/wireless/intel/iwlwifi/dvm/devices.c+4 -70 repliesApplied
11/12thermal: armada: remove unused TO_MCELSIUS macrodrivers/thermal/armada_thermal.c+0 -20 repliesApplied
12/12iio: adc: qcom-vadc-common: use <linux/units.h> helpersdrivers/iio/adc/qcom-vadc-common.c drivers/iio/adc/qcom-vadc-common.h+3 -41 replyApplied

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoChristoph HellwigGuenter RoeckKeith BuschKalle ValoLuca CoelhoJonathan Cameron
1/12R-b
2/12
3/12A-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b R-b R-b R-b
8/12R-b
9/12R-b A-b
10/12R-b A-b
11/12R-b
12/12R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] add header file for kelvin to/from Celsius conversion helpers

There are several helper macros to convert kelvin to/from Celsius in <linux/thermal.h> for thermal drivers. These are useful for any other drivers or subsystems, but it's odd to include <linux/thermal.h> just for the helpers.

This adds a new <linux/units.h> that provides the equivalent inline functions for any drivers or subsystems, and switches all the users of conversion helpers in <linux/thermal.h> to use <linux/units.h> helpers.

* v4
- add Reviewed-by and Acked-by tags
- change include order
- keep the line over 80 characters because this change doesn't make it longer
- remove "wireless: " in the title

* v3
- rename new header name from <linux/temperature.h> to <linux/units.h>
- add milli_kelvin_to_millicelsius() and millicelsius_to_milli_kelvin() and use them for implementing other helpers
- add MILLIDEGREE_PER_DEGREE and MILLIDEGREE_PER_DECIDEGREE and replace the hardcoded constants
- add kelvin_to_celsius() and celsius_to_kelvin() in <linux/units.h>
- add Reviewed-by tags
- switch iwlegacy driver to use <linux/units.h> helpers
- switch iwlwifi driver to use <linux/units.h> helpers
- remove unused TO_MCELSIUS macro in armada thermal driver
- switch qcom-vadc-common module to use <linux/units.h> helpers

* v2
- add deci_kelvin_to_millicelsius_with_offset() in linux/temperature.h
- stop including linux/temperature.h from linux/thermal.h
- include <linux/temperature.h> explicitly from thermal drivers
- fix s/temprature/temperature/ typo in commit log
- use deci_kelvin_to_millicelsius_with_offset() in ACPI thermal zone driver
- don't mix up another fix (format string for cellsius value)
- add Acked-by and Reviewed-by tags

Akinobu Mita (12):
add helpers for kelvin to/from Celsius conversion
ACPI: thermal: switch to use <linux/units.h> helpers platform/x86: asus-wmi: switch to use <linux/units.h> helpers platform/x86: intel_menlow: switch to use <linux/units.h> helpers
thermal: int340x: switch to use <linux/units.h> helpers
thermal: intel_pch: switch to use <linux/units.h> helpers
nvme: hwmon: switch to use <linux/units.h> helpers
thermal: remove kelvin to/from Celsius conversion helpers from
<linux/thermal.h>
iwlegacy: use <linux/units.h> helpers
iwlwifi: use <linux/units.h> helpers
thermal: armada: remove unused TO_MCELSIUS macro
iio: adc: qcom-vadc-common: use <linux/units.h> helpers

 drivers/acpi/thermal.c                             | 34 ++++-----
 drivers/iio/adc/qcom-vadc-common.c                 |  6 +-
 drivers/iio/adc/qcom-vadc-common.h                 |  1 -
 drivers/net/wireless/intel/iwlegacy/4965-mac.c     |  3 +-
 drivers/net/wireless/intel/iwlegacy/4965.c         | 11 +--
 drivers/net/wireless/intel/iwlegacy/common.h       |  3 -
 drivers/net/wireless/intel/iwlwifi/dvm/dev.h       |  5 --
 drivers/net/wireless/intel/iwlwifi/dvm/devices.c   |  6 +-
 drivers/nvme/host/hwmon.c                          | 13 ++--
 drivers/platform/x86/asus-wmi.c                    |  7 +-
 drivers/platform/x86/intel_menlow.c                |  9 ++-
 drivers/thermal/armada_thermal.c                   |  2 -
 .../intel/int340x_thermal/int340x_thermal_zone.c   |  7 +-
 drivers/thermal/intel/intel_pch_thermal.c          |  3 +-
 include/linux/thermal.h                            | 11 ---
 include/linux/units.h                              | 84 ++++++++++++++++++++++
 16 files changed, 137 insertions(+), 68 deletions(-)
 create mode 100644 include/linux/units.h
Cc Sujith Thomas <[email protected]>
Cc Darren Hart <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Amit Kucheria <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Keith Busch <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Sagi Grimberg <[email protected]>
Cc Kalle Valo <[email protected]>
Cc Stanislaw Gruszka <[email protected]>
Cc Johannes Berg <[email protected]>
Cc Emmanuel Grumbach <[email protected]>
Cc Luca Coelho <[email protected]>
Cc Intel Linux Wireless <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Signature · 1 line
2.7.4