Skip to content

net: bcmgenet: Turn on offloads by default

Doug Berger lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 3 repliesIn review
  2. v18 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: bcmgenet: enable NETIF_F_HIGHDMA flagdrivers/net/ethernet/broadcom/genet/bcmgenet.c+10 -20 replies
2/8net: bcmgenet: enable NETIF_F_HW_CSUM featuredrivers/net/ethernet/broadcom/genet/bcmgenet.c+12 -171 reply
3/8net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUMdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h+8 -131 reply
4/8net: bcmgenet: Refactor bcmgenet_set_features()drivers/net/ethernet/broadcom/genet/bcmgenet.c+19 -190 replies
5/8net: bcmgenet: Utilize bcmgenet_set_features() during resume/opendrivers/net/ethernet/broadcom/genet/bcmgenet.c+8 -00 replies
6/8net: bcmgenet: Turn on offloads by defaultdrivers/net/ethernet/broadcom/genet/bcmgenet.c+5 -30 replies
7/8net: bcmgenet: Be drop monitor friendly while re-allocating headroomdrivers/net/ethernet/broadcom/genet/bcmgenet.c+2 -10 replies
8/8net: bcmgenet: Add software counters to track reallocationsdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h+8 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/8] net: bcmgenet: Turn on offloads by default

This commit stack is based on Florian's commit 4e8aedfe78c7 ("net:
systemport: Turn on offloads by default") and enables the offloads for the bcmgenet driver by default.

The first commit adds support for the HIGHDMA feature to the driver.

The second converts the Tx checksum implementation to use the generic hardware logic rather than the deprecated IP centric methods.

The third modifies the Rx checksum implementation to use the hardware offload to compute the complete checksum rather than filtering out bad packets detected by the hardware's IP centric implementation. This may increase processing load by passing bad packets to the network stack, but it provides for more flexible handling of packets by the network stack without requiring software computation of the checksum.

The remaining commits mirror the extensions Florian made to the sysport driver to retain symmetry with that driver and to make the benefits of the hardware offloads more ubiquitous.

Doug Berger (8):
net: bcmgenet: enable NETIF_F_HIGHDMA flag
net: bcmgenet: enable NETIF_F_HW_CSUM feature
net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM
net: bcmgenet: Refactor bcmgenet_set_features()
net: bcmgenet: Utilize bcmgenet_set_features() during resume/open
net: bcmgenet: Turn on offloads by default
net: bcmgenet: Be drop monitor friendly while re-allocating headroom
net: bcmgenet: Add software counters to track reallocations

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 113 ++++++++++++++-----------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   4 +-
 2 files changed, 67 insertions(+), 50 deletions(-)
Signature · 6 lines
Changes in v2:
  - Added "Reviewed-by" where given
  - Removed no longer used private structure member dma_rx_chk_bit
  - Used __force casting to remove sparse warnings

2.7.4