Skip to content

Enhancements to at91-sama5d2_adc and rtc trigger

[email protected] linux-arm-kernel linux-devicetree linux-iio linux-rtc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10iio: adc: at91-sama5d2_adc: update for other trigger usagedrivers/iio/adc/at91-sama5d2_adc.c+127 -851 reply
2/10dt-bindings: iio: adc: at91-sama5d2: add rtc-trigger optional propertyDocumentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt+4 -01 reply
3/10dt-bindings: iio: trigger: at91-rtc-trigger: add bindingsDocumentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml+44 -01 reply
4/10rtc: at91rm9200: use of_platform_populate as return valuedrivers/rtc/rtc-at91rm9200.c+1 -18 replies
5/10iio: trigger: at91-rtc-trigger: introduce at91 rtc adc trigger driverdrivers/iio/trigger/Kconfig drivers/iio/trigger/Makefile drivers/iio/trigger/at91-rtc-trigger.c+224 -01 reply
6/10iio: adc: at91-sama5d2_adc: handle unfinished conversionsdrivers/iio/adc/at91-sama5d2_adc.c+22 -11 reply
7/10iio: adc: at91-sama5d2_adc: fix differential channels in triggered modedrivers/iio/adc/at91-sama5d2_adc.c+12 -01 reply
8/10iio: adc: at91-sama5d2_adc: implement RTC triggeringdrivers/iio/adc/at91-sama5d2_adc.c+104 -51 reply
9/10ARM: dts: at91: sama5d2: add rtc_adc_trigger nodearch/arm/boot/dts/sama5d2.dtsi+11 -00 replies
10/10ARM: dts: at91: sama5d2_xplained: enable rtc_adc_triggerarch/arm/boot/dts/at91-sama5d2_xplained.dts+4 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] Enhancements to at91-sama5d2_adc and rtc trigger

From: Eugen Hristev <[email protected]>

This series includes support for having the Real Time Clock trigger capability for the Analog to Digital Converter in sama5d2-based SoCs (RTC ADC Trigger)

The first patch of the series has been already submitted on the iio mailing list as
[PATCH] iio: adc: at91-sama5d2_adc: update for other trigger usage But I also include here for reference since the other commits on the driver use this as a base commit.

In short, the RTC block can trigger the ADC block to perform a conversion. To solve this, I created a driver named rtc-adc-trigger that shares the register map with the RTC. It's done in devicetree as a subnode. This driver will register a separate trigger inside the iio subsystem. This trigger can then be associated to the ADC driver (sysfs current_trigger). However, this is not enough. The ADC has to be aware that it;s being triggered by the RTC (TRGMOD and TRGSEL). So, this hardware link between the two IPs has been described as a phandle reference in the ADC node to the RTC trigger node.
At runtime (trigger selection), the ADC will check if the assigned trigger is the RTC one given by the phandle link. If so, it will configure accordingly.
The RTC trigger driver will also register to sysfs two attributes for selecting the desired trigger frequency.
One attribute is RO : list of possible frequencies.
Another attribute is RW: current set frequency.

To achieve all this, had to make a small patch on the RTC to populate child nodes platform data to probe them.

Fixed other issues with the adc driver: unfinished conversions on IRQ in triggered mode, and differential channels missing configurations in triggered mode.

For exercising this, created DT patches for sama5d2/sama5d2_xplained.

Here is a sample of how it works in sysfs:

 # cat /sys/bus/iio/devices/trigger0/trigger_frequency_hz
 1
 # echo 1 > /sys/bus/iio/devices/iio:device0/scan_elements/in_voltage4_en
 # cat /sys/bus/iio/devices/
 iio:device0/        iio_sysfs_trigger/  trigger0/           trigger1/
 # cat /sys/bus/iio/devices/trigger0/name
 f80480b0.at91_rtc_adc
 # iio_generic_buffer -n fc030000.adc -t f80480b0.at91_rtc_adc -c 5
 iio device number being used is 0
 iio trigger number being used is 0
 /sys/bus/iio/devices/iio:device0 f80480b0.at91_rtc_adc
 3298.388672
 3294.360352
 3291.943359
 3294.360352
 3291.943359

Future work:
In the future the node would have to be enabled for other sama5d2 based boards as well, and MAINTAINERS to be updated if this driver is accepted.

Eugen Hristev (10):
iio: adc: at91-sama5d2_adc: update for other trigger usage
dt-bindings: iio: adc: at91-sama5d2: add rtc-trigger optional property
dt-bindings: iio: trigger: at91-rtc-trigger: add bindings
rtc: at91rm9200: use of_platform_populate as return value
iio: trigger: at91-rtc-trigger: introduce at91 rtc adc trigger driver
iio: adc: at91-sama5d2_adc: handle unfinished conversions
iio: adc: at91-sama5d2_adc: fix differential channels in triggered
mode
iio: adc: at91-sama5d2_adc: implement RTC triggering
ARM: dts: at91: sama5d2: add rtc_adc_trigger node
ARM: dts: at91: sama5d2_xplained: enable rtc_adc_trigger

 .../bindings/iio/adc/at91-sama5d2_adc.txt          |   4 +
 .../bindings/iio/trigger/at91-rtc-trigger.yaml     |  44 +++
 arch/arm/boot/dts/at91-sama5d2_xplained.dts        |   4 +
 arch/arm/boot/dts/sama5d2.dtsi                     |  11 +
 drivers/iio/adc/at91-sama5d2_adc.c                 | 336 ++++++++++++++++-----
 drivers/iio/trigger/Kconfig                        |  10 +
 drivers/iio/trigger/Makefile                       |   1 +
 drivers/iio/trigger/at91-rtc-trigger.c             | 213 +++++++++++++
 drivers/rtc/rtc-at91rm9200.c                       |   2 +-
 9 files changed, 543 insertions(+), 82 deletions(-)
 create mode 040000 Documentation/devicetree/bindings/iio/trigger
 create mode 100644 Documentation/devicetree/bindings/iio/trigger/at91-rtc-trigger.yaml
 create mode 100644 drivers/iio/trigger/at91-rtc-trigger.c
Signature · 1 line
2.7.4