Skip to content

IOMMU user API enhancement

Jacob Pan linux-iommu lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 14 repliesIn review
  2. v66 patches 5 repliesSuperseded
  3. v55 patches 13 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v45 patches10 repliesSuperseded
v35 patches13 repliesSuperseded
v2 posting 2/23 patches27 repliesSuperseded
v2 posting 1/23 patches23 repliesSuperseded
v13 patches13 repliesSuperseded

v3 from the cover letter

- Rewrote backward compatibility rule to support existing code re-compiled with newer kernel UAPI header that runs on older kernel. Based on review comment from Alex W.
https://lore.kernel.org/linux-iommu/[email protected]/
- Take user pointer directly in UAPI functions. Perform argsz check and copy_from_user() in IOMMU driver. Eliminate the need for VFIO or other upper layer to parse IOMMU data.
- Create wrapper function for in-kernel users of UAPI functions

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7docs: IOMMU user APIDocumentation/userspace-api/iommu.rst MAINTAINERS+213 -02 replies
2/7iommu/uapi: Add argsz for user filled datainclude/uapi/linux/iommu.h+9 -32 replies
3/7iommu/uapi: Introduce enum type for PASID data formatinclude/uapi/linux/iommu.h+6 -21 reply
4/7iommu/uapi: Use named union for user datadrivers/iommu/intel/iommu.c drivers/iommu/intel/svm.c include/uapi/linux/iommu.h+14 -140 replies
5/7iommu/uapi: Rename uapi functionsdrivers/iommu/iommu.c include/linux/iommu.h+25 -242 replies
6/7iommu/uapi: Handle data and argsz filled by usersdrivers/iommu/iommu.c include/linux/iommu.h+212 -175 replies
7/7iommu/vt-d: Check UAPI data processed by IOMMU coredrivers/iommu/intel/iommu.c drivers/iommu/intel/svm.c+6 -42 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchLu BaoluEric Auger
1/7R-b
2/7R-b
3/7R-b
4/7R-b R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/7] IOMMU user API enhancement

IOMMU user API header was introduced to support nested DMA translation and related fault handling. The current UAPI data structures consist of three areas that cover the interactions between host kernel and guest:
- fault handling
- cache invalidation
- bind guest page tables, i.e. guest PASID

Future extensions are likely to support more architectures and vIOMMU features.

In the previous discussion, using user-filled data size and feature flags is made a preferred approach over a unified version number.
https://lkml.org/lkml/2020/1/29/45

In addition to introduce argsz field to data structures, this patchset is also trying to document the UAPI design, usage, and extension rules. VT-d driver changes to utilize the new argsz field is included, VFIO usage is to follow.

This set is available at:
https://github.com/jacobpan/linux.git vsva_v5.8_uapi_v7

Thanks,

Jacob

Changeog:
v7
- Added PASID data format enum for range checking
- Tidy up based on reviews from Alex W.
- Removed doc section for vIOMMU fault handling
v6
- Renamed all UAPI functions with iommu_uapi_ prefix
- Replaced argsz maxsz checking with flag specific size checks
- Documentation improvements based on suggestions by Eric Auger Replaced example code with a pointer to the actual code
- Added more checks for illegal flags combinations
- Added doc file to MAINTAINERS
v5
- Addjusted paddings in UAPI data to be 8 byte aligned
- Do not clobber argsz in IOMMU core before passing on to vendor driver
- Removed pr_warn_ for invalid UAPI data check, just return -EINVAL
- Clarified VFIO responsibility in UAPI data handling
- Use iommu_uapi prefix to differentiate APIs has in-kernel caller
- Added comment for unchecked flags of invalidation granularity
- Added example in doc to show vendor data checking

v4
- Added checks of UAPI data for reserved fields, version, and flags.
- Removed version check from vendor driver (vt-d)
- Relaxed argsz check to match the UAPI struct size instead of variable union size
- Updated documentation

v3:
- Rewrote backward compatibility rule to support existing code re-compiled with newer kernel UAPI header that runs on older kernel. Based on review comment from Alex W.
https://lore.kernel.org/linux-iommu/[email protected]/
- Take user pointer directly in UAPI functions. Perform argsz check and copy_from_user() in IOMMU driver. Eliminate the need for VFIO or other upper layer to parse IOMMU data.
- Create wrapper function for in-kernel users of UAPI functions
v2:
- Removed unified API version and helper
- Introduced argsz for each UAPI data
- Introduced UAPI doc

Jacob Pan (7):
docs: IOMMU user API
iommu/uapi: Add argsz for user filled data iommu/uapi: Introduce enum type for PASID data format iommu/uapi: Use named union for user data iommu/uapi: Rename uapi functions iommu/uapi: Handle data and argsz filled by users iommu/vt-d: Check UAPI data processed by IOMMU core

 Documentation/userspace-api/iommu.rst | 212 ++++++++++++++++++++++++++++++++++
 MAINTAINERS                           |   1 +
 drivers/iommu/intel/iommu.c           |  25 ++--
 drivers/iommu/intel/svm.c             |   9 +-
 drivers/iommu/iommu.c                 | 205 ++++++++++++++++++++++++++++++--
 include/linux/iommu.h                 |  35 ++++--
 include/uapi/linux/iommu.h            |  24 ++--
 7 files changed, 466 insertions(+), 45 deletions(-)
 create mode 100644 Documentation/userspace-api/iommu.rst
Signature · 6 lines
2.7.4

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu