Skip to content

RFC PCIe Hotplug Slot Emulation driver

Jon Derrick linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9PCI: pci-bridge-emul: Update PCIe register behaviorsdrivers/pci/pci-bridge-emul.c+27 -272 replies
2/9PCI: pci-bridge-emul: Eliminate reserved memberdrivers/pci/pci-bridge-emul.c+11 -171 reply
3/9PCI: pci-bridge-emul: Provide a helper to set behaviordrivers/pci/pci-bridge-emul.c drivers/pci/pci-bridge-emul.h+29 -00 replies
4/9PCI: pciehp: Indirect slot register operationsdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_hpc.c+93 -310 replies
5/9PCI: Add pcie_port_slot_emulated stubdrivers/pci/pci-acpi.c drivers/pci/pcie/portdrv_core.c drivers/pci/probe.c +1 more+14 -40 replies
6/9PCI: pciehp: Expose the poll loop to other driversdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_hpc.c+15 -30 replies
7/9PCI: Move pci_dev_str_match to search.cdrivers/pci/pci.c drivers/pci/search.c include/linux/pci.h+164 -1630 replies
8/9PCI: pciehp: Add hotplug slot emulation driverdrivers/pci/hotplug/Makefile drivers/pci/hotplug/pciehp_emul.c drivers/pci/pcie/Kconfig+391 -00 replies
9/9PCI: pciehp: Wire up pcie_port_emulate_slot and pciehp_emuldrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_emul.c drivers/pci/hotplug/pciehp_hpc.c +2 more+37 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/9] PCIe Hotplug Slot Emulation driver

This set adds an emulation driver for PCIe Hotplug. There may be platforms with specific configurations that can support hotplug but don't provide the logical slot hotplug hardware. For instance, the platform may use an electrically-tolerant interposer between the slot and the device.

This driver utilizes the pci-bridge-emul architecture to manage register reads and writes. The underlying functionality of the hotplug emulation driver uses the Data Link Layer Link Active Reporting mechanism in a polling loop, but can tolerate other event sources such as AER or DPC.

When enabled and a slot is managed by the driver, all port services are managed by the kernel. This is done to ensure that firmware hotplug and error architecture does not (correctly) halt/machine check the system when hotplug is performed on a non-hotplug slot.

The driver offers two active mode: Auto and Force.
auto: The driver will bind to non-hotplug slots
force: The driver will bind to all slots and overrides the slot's services

There are three kernel params:
pciehp.pciehp_emul_mode={off, auto, force} pciehp.pciehp_emul_time=<msecs polling time> (def 1000, min 100, max 60000) pciehp.pciehp_emul_ports=<PCI [S]BDF/ID format string>

The pciehp_emul_ports kernel parameter takes a semi-colon tokenized string representing PCI [S]BDFs and IDs. The pciehp_emul_mode will then be applied to only those slots, leaving other slots unmanaged by pciehp_emul.

The string follows the pci_dev_str_match() format:

[<domain>:]<bus>:<device>.<func>[/<device>.<func>]* pci:<vendor>:<device>[:<subvendor>:<subdevice>]

When using the path format, the path for the device can be obtained using 'lspci -t' and further specified using the upstream bridge and the downstream port's device-function to be more robust against bus renumbering.

When using the vendor-device format, a value of '0' in any field acts as a wildcard for that field, matching all values.

The driver is enabled with CONFIG_HOTPLUG_PCI_PCIE_EMUL=y.

The driver should be considered 'use at own risk' unless the platform/hardware vendor recommends this mode.

Jon Derrick (9):
PCI: pci-bridge-emul: Update PCIe register behaviors
PCI: pci-bridge-emul: Eliminate reserved member
PCI: pci-bridge-emul: Provide a helper to set behavior
PCI: pciehp: Indirect slot register operations
PCI: Add pcie_port_slot_emulated stub
PCI: pciehp: Expose the poll loop to other drivers
PCI: Move pci_dev_str_match to search.c
PCI: pciehp: Add hotplug slot emulation driver
PCI: pciehp: Wire up pcie_port_emulate_slot and pciehp_emul

 drivers/pci/hotplug/Makefile      |   4 +
 drivers/pci/hotplug/pciehp.h      |  28 +++
 drivers/pci/hotplug/pciehp_emul.c | 378 ++++++++++++++++++++++++++++++++++++++
 drivers/pci/hotplug/pciehp_hpc.c  | 136 ++++++++++----
 drivers/pci/pci-acpi.c            |   3 +
 drivers/pci/pci-bridge-emul.c     |  95 +++++-----
 drivers/pci/pci-bridge-emul.h     |  10 +
 drivers/pci/pci.c                 | 163 ----------------
 drivers/pci/pcie/Kconfig          |  14 ++
 drivers/pci/pcie/portdrv_core.c   |  14 +-
 drivers/pci/probe.c               |   2 +-
 drivers/pci/search.c              | 162 ++++++++++++++++
 include/linux/pci.h               |   8 +
 13 files changed, 775 insertions(+), 242 deletions(-)
 create mode 100644 drivers/pci/hotplug/pciehp_emul.c
Signature · 1 line
1.8.3.1