Skip to content

Fix RX cancel command failure

satya priya linux-arm-msm linux-serial 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

- As per Stephen's comment, change the declaration of rx_fifo pointer from u32 to void.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probedrivers/tty/serial/qcom_geni_serial.c+9 -100 replies
2/2tty: serial: qcom_geni_serial: Fix RX cancel command failuredrivers/tty/serial/qcom_geni_serial.c+14 -44 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchStephen Boyd
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/2] Fix RX cancel command failure

Changes in V2:
- Add patch to allocate port->rx_fifo buffer in probe to resolve NULL pointer dereference crash reported by stephen.

The crash is caused due to set_termios call starting RX engine and RX engine is sampling some garbage data from line, and by the time startup is called, we have few data to read but port->rx_fifo buffer is not allocated causing NULL pointer dereference.

Changes in V3:
- As per Stephen's comment, change the declaration of rx_fifo pointer from u32 to void.

satya priya (2):
tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe
tty: serial: qcom_geni_serial: Fix RX cancel command failure

 drivers/tty/serial/qcom_geni_serial.c | 37 ++++++++++++++++++++++-------------
 1 file changed, 23 insertions(+), 14 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation