Skip to content

block/diskstats: more accurate io_ticks and optimization

Konstantin Khlebnikov linux-block lkml 3 versions – In review

Get series with b4
b4 am 158514148436.7009.1234367408038809210.stgit@buzz

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v33 patches 8 repliesSuperseded
  3. v13 patches 1 replySuperseded

Changes in v4 from the cover letter

* rebase to for-5.7/block
* make part_stat_read_all static in block/genhd.c

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block/diskstats: more accurate approximation of io_ticks for slow disksDocumentation/admin-guide/iostats.rst block/bio.c block/blk-core.c +1 more+11 -80 replies
2/3block/diskstats: accumulate all per-cpu counters in one passblock/genhd.c include/linux/genhd.h+70 -350 replies
3/3block/diskstats: replace time_in_queue with sum of request timesblock/bio.c block/blk-core.c block/genhd.c +1 more+10 -60 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMing Lei
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] block/diskstats: more accurate io_ticks and optimization

Simplified estimation for io_ticks introduced in patch
https://lore.kernel.org/linux-block/[email protected]/
could be very inaccurate for request longer than jiffy (i.e. any HDD)

There is at least one another report about this:
https://lore.kernel.org/linux-block/[email protected]/
See detail in comment for first patch.

v1: https://lore.kernel.org/lkml/155413438394.3201.15211440151043943989.stgit@buzz/
v2: https://lore.kernel.org/lkml/158314549775.1788.6529015932237292177.stgit@buzz/
v3: https://lore.kernel.org/lkml/158503038812.1955.7827988255138056389.stgit@buzz/
* update documentation
* rebase to current linux-next
* fix compilation for CONFIG_SMP=n
v4:
* rebase to for-5.7/block
* make part_stat_read_all static in block/genhd.c

---

Konstantin Khlebnikov (3):
block/diskstats: more accurate approximation of io_ticks for slow disks block/diskstats: accumulate all per-cpu counters in one pass block/diskstats: replace time_in_queue with sum of request times

 Documentation/admin-guide/iostats.rst |    5 +-
 block/bio.c                           |    9 +--
 block/blk-core.c                      |    5 +-
 block/genhd.c                         |  109 +++++++++++++++++++++++----------
 include/linux/genhd.h                 |    6 --
 5 files changed, 88 insertions(+), 46 deletions(-)

--
Signature