Skip to content

Add support for WLED5

Kiran Gunda dri-devel linux-arm-msm linux-devicetree linux-fbdev linux-leds lkml 6 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 9 repliesApplied
  2. v54 patches 8 repliesSuperseded
  3. v44 patches 11 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches10 repliesSuperseded
v22 patches0 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v6 from the cover letter

- This series depends on the below patch.
https://lore.kernel.org/patchwork/patch/1226258/
- Addressed yaml formatting comments from Rob Herring.
- Removed the "wled_ovp_fault_status" callback as per Daniel Thomson suggestion from patch #2.
- Addressed comments from Daniel Thomson on patch #4.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4backlight: qcom-wled: convert the wled bindings to .yaml formatDocumentation/devicetree/bindings/leds/backlight/qcom-wled.txt Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml+208 -1543 replies
2/4backlight: qcom-wled: Add callback functionsdrivers/video/backlight/qcom-wled.c+141 -721 reply
3/4backlight: qcom-wled: Add WLED5 bindingsDocumentation/devicetree/bindings/leds/backlight/qcom-wled.yaml+56 -33 replies
4/4backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICsdrivers/video/backlight/qcom-wled.c+376 -22 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel ThompsonRob Herring
1/4A-b R-b
2/4R-b
3/4A-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH V6 0/4] Add support for WLED5

Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L.

PM8150L WLED supports the following.
- Two modulators and each sink can use any of the modulator
- Multiple CABC selection options
- Multiple brightness width selection (12 bits to 15 bits)

Changes from V1:
- Rebased on top of the below commit.
backlight: qcom-wled: Fix unsigned comparison to zero

Changes from V2:
- Addressed Bjorn's comments by splitting the WLED4 changes in a seperate patch.
- Added WLED5 auto calibration support

Changes from V3:
- Addressed comments from Daniel Thompson and Rob Herring
- Seperated the WLED5 bindings from the driver changes
- Squashed wled5 auto string detection and wled5 basic changes to avoid the NULL callback function pointer issue.

Changes from V4:
- Addressed the yaml formatting comments from Rob Herring.
- Addressed the comments from Daniel Thompson on the below patch "backlight: qcom-wled: Add callback functions"

Changes from V5:
- This series depends on the below patch.
https://lore.kernel.org/patchwork/patch/1226258/
- Addressed yaml formatting comments from Rob Herring.
- Removed the "wled_ovp_fault_status" callback as per Daniel Thomson suggestion from patch #2.
- Addressed comments from Daniel Thomson on patch #4.

Kiran Gunda (3):
backlight: qcom-wled: convert the wled bindings to .yaml format
backlight: qcom-wled: Add callback functions
backlight: qcom-wled: Add WLED5 bindings

Subbaraman Narayanamurthy (1):
backlight: qcom-wled: Add support for WLED5 peripheral that is present
on PM8150L PMICs

 .../bindings/leds/backlight/qcom-wled.txt          | 154 ------
 .../bindings/leds/backlight/qcom-wled.yaml         | 261 +++++++++
 drivers/video/backlight/qcom-wled.c                | 589 ++++++++++++++++++---
 3 files changed, 777 insertions(+), 227 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project