Add interconnect support to QSPI and QUP drivers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest8 patches 4 repliesIn review
- v7 posting 2/27 patches 9 repliesSuperseded
- v7 posting 1/27 patches 4 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 7 patches | 5 replies | Superseded | |
| v5 posting 2/2 | 0 of 7 patches | 0 replies | Superseded | |
| v5 posting 1/2 | 7 patches | 19 replies | Superseded | |
| v4 | 9 patches | 12 replies | Superseded | |
| v3 | 8 patches | 32 replies | Superseded | |
| v2 | 8 patches | 41 replies | Superseded |
Changes in v8 from the cover letter
- Add [PATCH V8 5/8] to factor out common code for clock setting.
- Combine ICC voting and clock setting to single API. [PATCH V8 6/8]
- Add ICC voting per transfer because in case of multi message, transfer frequency can vary for each message/transfer.[PATCH V8 6/8]
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | soc: qcom: geni: Support for ICC votingdrivers/ include/ | +120 | 0 replies | |
| 2/8 | soc: qcom-geni-se: Add interconnect support to fix earlycon crashdrivers/ drivers/ include/ | +77 | 0 replies | |
| 3/8 | i2c: i2c-qcom-geni: Add interconnect supportdrivers/ | +25 | 0 replies | |
| 4/8 | tty: serial: qcom_geni_serial: Add interconnect supportdrivers/ | +28 | 0 replies | |
| 5/8 | spi: spi-geni-qcom: Combine the clock setting codedrivers/ | +35 | 1 reply | |
| 6/8 | spi: spi-geni-qcom: Add interconnect supportdrivers/ | +32 | 1 reply | |
| 7/8 | spi: spi-qcom-qspi: Add interconnect supportdrivers/ | +55 | 1 reply | |
| 8/8 | arm64: dts: sc7180: Add interconnect for QUP and QSPIarch/ | +127 | 0 replies |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Matthias Kaehlcke | Greg Kroah-Hartman | Wolfram Sang | Mark Brown |
|---|---|---|---|---|
| 1/8 | R-b | |||
| 2/8 | R-b | |||
| 3/8 | R-b | A-b | ||
| 4/8 | R-b | A-b | ||
| 5/8 | A-b | |||
| 6/8 | A-b | |||
| 7/8 | R-b | A-b | ||
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH V8 0/8] Add interconnect support to QSPI and QUP drivers
This patch series is based on tag "next-20200622" of linux-next tree.
High level design:
- QUP wrapper/common driver.
Vote for QUP core on behalf of earlycon from probe. Remove BW vote during earlycon exit call
- SERIAL driver.
Vote only for CPU/CORE path because driver is in FIFO mode only Vote/unvote from qcom_geni_serial_pm func.
Bump up the CPU vote from set_termios call based on real time need
- I2C driver.
Vote for CORE/CPU/DDR path
Vote/unvote from runtime resume/suspend callback
As bus speed for I2C is fixed from probe itself no need for bump up.
- SPI QUP driver.
Vote only for CPU/CORE path because driver is in FIFO mode only Vote/unvote from runtime resume/suspend callback Bump up CPU vote based on real time need per transfer.
- QSPI driver.
Vote only for CPU path
Vote/unvote from runtime resume/suspend callback Bump up CPU vote based on real time need per transfer.
Changes in V2:
- Add devm_of_icc_get() API interconnect core.
- Add ICC support to common driver to fix earlyconsole crash.
Changes in V3:
- Define common ICC APIs in geni-se driver and use it across geni based I2C,SPI and UART driver.
Changes in V4:
- Add a patch to ICC core to scale peak requirement as twice of average if it is not mentioned explicilty.
Changes in V5:
- As per Georgi's suggestion removed patch from ICC core for assuming peak_bw as twice of average when it's not mentioned, instead assume it equall to avg_bw and keep this assumption in ICC client itself.
- As per Matthias suggestion use enum for GENI QUP ICC paths.
Changes in V6:
- No Major change
Changes in V7:
- As per Matthias's comment removed usage of peak_bw variable because we don't have explicit peak requirement, we were voting peak = avg and this can be tracked using single variable for avg bw.
- As per Matthias's comment improved print log.
Changes in V8:
- Add [PATCH V8 5/8] to factor out common code for clock setting.
- Combine ICC voting and clock setting to single API. [PATCH V8 6/8]
- Add ICC voting per transfer because in case of multi message, transfer frequency can vary for each message/transfer.[PATCH V8 6/8]
Akash Asthana (7):
soc: qcom: geni: Support for ICC voting
soc: qcom-geni-se: Add interconnect support to fix earlycon crash
i2c: i2c-qcom-geni: Add interconnect support
tty: serial: qcom_geni_serial: Add interconnect support
spi: spi-geni-qcom: Add interconnect support
spi: spi-qcom-qspi: Add interconnect support
arm64: dts: sc7180: Add interconnect for QUP and QSPI
Douglas Anderson (1):
spi: spi-geni-qcom: Combine the clock setting code
arch/arm64/boot/dts/qcom/sc7180.dtsi | 127 ++++++++++++++++++++++++++++ drivers/i2c/busses/i2c-qcom-geni.c | 26 +++++- drivers/soc/qcom/qcom-geni-se.c | 150 ++++++++++++++++++++++++++++++++++ drivers/spi/spi-geni-qcom.c | 100 +++++++++++++++-------- drivers/spi/spi-qcom-qspi.c | 56 ++++++++++++- drivers/tty/serial/qcom_geni_serial.c | 38 ++++++++- include/linux/qcom-geni-se.h | 40 +++++++++ 7 files changed, 496 insertions(+), 41 deletions(-)
Signature · 1 line
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project