ceph: add min/max/stdev latency support
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest4 patches 4 repliesIn review
Changes in v4 from the cover letter
- fix the 32-bit arches div errors by using DIV64_U64_ROUND_CLOSEST instead. [1/4]
- rebase and combine the stdev patch series [3/4][4/4]
- remove the sum latency showing, which makes no sense for debugging, if it is really needed in some case then just do (avg * total) in userland. [4/4]
- switch {read/write/metadata}_latency_sum to atomic type since it will be readed very time when updating the latencies to calculate the stdev. [4/4]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | ceph: switch to DIV64_U64_ROUND_CLOSEST to support 32-bit archesfs/ | +3 | 0 replies | |
| 2/4 | ceph: add min/max latency support for read/write/metadata metricsfs/ fs/ fs/ | +78 | 0 replies | |
| 3/4 | ceph: move the metric helpers into one separate filefs/ fs/ fs/ +1 more | +190 | 0 replies | |
| 4/4 | ceph: add standard deviation support for read/write/metadata perf metricfs/ fs/ fs/ | +129 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 0/4] ceph: add min/max/stdev latency support
From: Xiubo Li <[email protected]>
Changed in V4:
- fix the 32-bit arches div errors by using DIV64_U64_ROUND_CLOSEST instead. [1/4]
- rebase and combine the stdev patch series [3/4][4/4]
- remove the sum latency showing, which makes no sense for debugging, if it is really needed in some case then just do (avg * total) in userland. [4/4]
- switch {read/write/metadata}_latency_sum to atomic type since it will be readed very time when updating the latencies to calculate the stdev. [4/4]
Changed in V2:
- switch spin lock to cmpxchg [1/4]
Changed in V3:
- add the __update_min/max_latency helpers [1/4]
# cat /sys/kernel/debug/ceph/0f923fe5-00e6-4866-bf01-2027cb75e94b.client4150/metrics item total avg_lat(us) min_lat(us) max_lat(us) stdev(us) ----------------------------------------------------------------------------------- read 2312 9000 1000 100000 607.4 write 21777 925000 2000 44551000 29700.3 metadata 6 4179000 1000 21414000 19590.8
item total miss hit
-------------------------------------------------
d_lease 2 0 11 caps 2 14 398418
Xiubo Li (4):
ceph: switch to DIV64_U64_ROUND_CLOSEST to support 32-bit arches
ceph: add min/max latency support for read/write/metadata metrics
ceph: move the metric helpers into one separate file
ceph: add standard deviation support for read/write/metadata perf
metric
fs/ceph/Makefile | 2 +- fs/ceph/debugfs.c | 89 ++++++++++++++++++------ fs/ceph/mds_client.c | 83 +--------------------- fs/ceph/metric.c | 190 +++++++++++++++++++++++++++++++++++++++++++++++++++ fs/ceph/metric.h | 79 +++++++++++---------- 5 files changed, 297 insertions(+), 146 deletions(-) create mode 100644 fs/ceph/metric.c
Signature · 1 line
1.8.3.1