Skip to content

Tegra XUSB charger detect support

Nagarjuna Kristam linux-devicetree linux-tegra lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 3 repliesIn review
  2. v47 patches 2 repliesSuperseded
  3. v38 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v28 patches15 repliesSuperseded
v18 patches4 repliesSuperseded

Changes in v5 from the cover letter

- Fixed kernel robot warnings to updated functions as static.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7dt-bindings: phy: tegra-xusb: Add charger-detect propertyDocumentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt+4 -00 replies
2/7phy: tegra: xusb: Add support for UTMI pad power controldrivers/phy/tegra/xusb-tegra186.c drivers/phy/tegra/xusb.h+26 -270 replies
3/7phy: tegra: xusb: Add USB2 pad power control support for Tegra210drivers/phy/tegra/xusb-tegra210.c+133 -571 reply
4/7phy: tegra: xusb: Add soc ops API to enable UTMI PAD protectiondrivers/phy/tegra/xusb-tegra186.c drivers/phy/tegra/xusb-tegra210.c drivers/phy/tegra/xusb.h+85 -01 reply
5/7phy: tegra: xusb: Add support for charger detectdrivers/phy/tegra/Makefile drivers/phy/tegra/cd.c drivers/phy/tegra/xusb.c +1 more+371 -11 reply
6/7phy: tegra: xusb: Enable charger detect for Tegra186drivers/phy/tegra/xusb-tegra186.c+1 -00 replies
7/7phy: tegra: xusb: Enable charger detect for Tegra210drivers/phy/tegra/xusb-tegra210.c+1 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRob HerringThierry Reding
1/7A-b A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH V5 0/7] Tegra XUSB charger detect support

This patch series adds charger detect support on XUSB hardware used in Tegra210 and Tegra186 SoCs.

This patchset is composed with :
- dt bindings of XUSB Pad Controller
- Tegra XUSB device mode driver to add vbus_draw support
- Tegra PHY driver for charger detect support

Tests done:
- Connect USB cable from ubuntu host to micro-B port of DUT to detect SDP_TYPE charger
- Connect USB cable from external powered USB hub(which inturn connects to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger.
- Connect USB cable from USB charger to micro-B port of DUT to detect DCP_TYPE charger.
DUT: Jetson-tx1, Jetson tx2.

V5:
- Fixed kernel robot warnings to updated functions as static.
V4:
- Added ACKed-by details for PHY driver.
- Used BIT macro instead of (1 << index) usage as suggested by Chunfeng Yun.
V3:
- Added ACKed-by details for PHY driver and DT changes.
- Functions and its arguments are aligned.
- Tabs are used for alignment of MACRO's
- For vbus_draw USDC callback, usb_phy set_power error is propogated.
- Fixed various comments given by thierry.
V2:
- Added ACKed-by details for DT patches.
- All patches rebased.

Nagarjuna Kristam (7):
dt-bindings: phy: tegra-xusb: Add charger-detect property
phy: tegra: xusb: Add support for UTMI pad power control
phy: tegra: xusb: Add USB2 pad power control support for Tegra210
phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection
phy: tegra: xusb: Add support for charger detect
phy: tegra: xusb: Enable charger detect for Tegra186
phy: tegra: xusb: Enable charger detect for Tegra210

 .../bindings/phy/nvidia,tegra124-xusb-padctl.txt   |   4 +
 drivers/phy/tegra/Makefile                         |   2 +-
 drivers/phy/tegra/cd.c                             | 283 +++++++++++++++++++++
 drivers/phy/tegra/xusb-tegra186.c                  |  92 +++++--
 drivers/phy/tegra/xusb-tegra210.c                  | 223 +++++++++++-----
 drivers/phy/tegra/xusb.c                           |  80 ++++++
 drivers/phy/tegra/xusb.h                           |  22 ++
 7 files changed, 621 insertions(+), 85 deletions(-)
 create mode 100644 drivers/phy/tegra/cd.c
Signature · 1 line
2.7.4