Skip to content

Bug fixes and improved logging in MHI

Bhaumik Bhatt linux-arm-msm lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest8 patches 9 repliesIn review
  2. v68 patches 7 repliesSuperseded
  3. v58 patches 2 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v48 patches3 repliesSuperseded
v39 patches11 repliesSuperseded
v28 patches7 repliesSuperseded
v1 posting 2/28 patches2 repliesSuperseded
v1 posting 1/28 patches0 repliesSuperseded

Changes in v7 from the cover letter

-Updated commit text for macro inclusion
-Updated channel ID bound checks
-Fixed non-uniform placement of function parameters to be within 80 characters -Sent to correct Maintainer email ID

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8bus: mhi: core: Refactor mhi queue APIsdrivers/bus/mhi/core/internal.h drivers/bus/mhi/core/main.c+47 -631 reply
2/8bus: mhi: core: Cache intmod from mhi event to mhi channeldrivers/bus/mhi/core/init.c+4 -01 reply
3/8bus: mhi: core: Add range check for channel id received in event ringdrivers/bus/mhi/core/main.c+29 -111 reply
4/8bus: mhi: core: Read transfer length from an event properlydrivers/bus/mhi/core/main.c+7 -21 reply
5/8bus: mhi: core: Handle firmware load using state workerdrivers/bus/mhi/core/boot.c drivers/bus/mhi/core/init.c drivers/bus/mhi/core/internal.h +2 more+5 -231 reply
6/8bus: mhi: core: Return appropriate error codes for AMSS load failuredrivers/bus/mhi/core/boot.c+12 -111 reply
7/8bus: mhi: core: Improve debug logs for loading firmwaredrivers/bus/mhi/core/boot.c+18 -31 reply
8/8bus: mhi: core: Ensure non-zero session or sequence ID values are useddrivers/bus/mhi/core/boot.c drivers/bus/mhi/core/internal.h+8 -81 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchJeffrey HugoManivannan Sadhasivam
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/8] Bug fixes and improved logging in MHI

A set of patches for bug fixes and improved logging in mhi/core/boot.c. Verified on x86 and arm64 platforms.

v7:
-Updated commit text for macro inclusion
-Updated channel ID bound checks
-Fixed non-uniform placement of function parameters to be within 80 characters -Sent to correct Maintainer email ID

v6:
-Updated the MHI_RANDOM_U32_NONZERO to only give a random number upto the supplied bitmask

v5:
-Updated the macro MHI_RANDOM_U32_NONZERO to take a bitmask as the input parameter and output a non-zero value between 1 and U32_MAX

v4:
-Dropped the change: bus: mhi: core: WARN_ON for malformed vector table -Updated bus: mhi: core: Read transfer length from an event properly to include parse rsc events
-Use prandom_u32_max() instead of prandom_u32 to avoid if check in
bus: mhi: core: Ensure non-zero session or sequence ID values are used

v3:
-Fixed signed-off-by tags
-Add a refactor patch for MHI queue APIs
-Commit text fix in bus: mhi: core: Read transfer length from an event properly -Fix channel ID range check for ctrl and data event rings processing

v2:
-Fix channel ID range check potential infinite loop -Add appropriate signed-off-by tags

Bhaumik Bhatt (4):
bus: mhi: core: Handle firmware load using state worker
bus: mhi: core: Return appropriate error codes for AMSS load failure
bus: mhi: core: Improve debug logs for loading firmware
bus: mhi: core: Ensure non-zero session or sequence ID values are used

Hemant Kumar (4):
bus: mhi: core: Refactor mhi queue APIs
bus: mhi: core: Cache intmod from mhi event to mhi channel
bus: mhi: core: Add range check for channel id received in event ring
bus: mhi: core: Read transfer length from an event properly

 drivers/bus/mhi/core/boot.c     |  75 +++++++++----------
 drivers/bus/mhi/core/init.c     |   5 +-
 drivers/bus/mhi/core/internal.h |   5 +-
 drivers/bus/mhi/core/main.c     | 156 +++++++++++++++++++++-------------------
 drivers/bus/mhi/core/pm.c       |   6 +-
 include/linux/mhi.h             |   2 -
 6 files changed, 129 insertions(+), 120 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project