Bug fixes and improved logging in MHI
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest8 patches 9 repliesIn review
- v68 patches 7 repliesSuperseded
- v58 patches 2 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 8 patches | 3 replies | Superseded | |
| v3 | 9 patches | 11 replies | Superseded | |
| v2 | 8 patches | 7 replies | Superseded | |
| v1 posting 2/2 | 8 patches | 2 replies | Superseded | |
| v1 posting 1/2 | 8 patches | 0 replies | Superseded |
Changes in v7 from the cover letter
-Updated commit text for macro inclusion
-Updated channel ID bound checks
-Fixed non-uniform placement of function parameters to be within 80 characters -Sent to correct Maintainer email ID
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | bus: mhi: core: Refactor mhi queue APIsdrivers/ drivers/ | +47 | 1 reply | |
| 2/8 | bus: mhi: core: Cache intmod from mhi event to mhi channeldrivers/ | +4 | 1 reply | |
| 3/8 | bus: mhi: core: Add range check for channel id received in event ringdrivers/ | +29 | 1 reply | |
| 4/8 | bus: mhi: core: Read transfer length from an event properlydrivers/ | +7 | 1 reply | |
| 5/8 | bus: mhi: core: Handle firmware load using state workerdrivers/ drivers/ drivers/ +2 more | +5 | 1 reply | |
| 6/8 | bus: mhi: core: Return appropriate error codes for AMSS load failuredrivers/ | +12 | 1 reply | |
| 7/8 | bus: mhi: core: Improve debug logs for loading firmwaredrivers/ | +18 | 1 reply | |
| 8/8 | bus: mhi: core: Ensure non-zero session or sequence ID values are useddrivers/ drivers/ | +8 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Jeffrey Hugo | Manivannan Sadhasivam |
|---|---|---|
| 1/8 | R-b | R-b |
| 2/8 | R-b | R-b |
| 3/8 | R-b | R-b |
| 4/8 | R-b | R-b |
| 5/8 | R-b | R-b |
| 6/8 | R-b | R-b |
| 7/8 | R-b | R-b |
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/8] Bug fixes and improved logging in MHI
A set of patches for bug fixes and improved logging in mhi/core/boot.c. Verified on x86 and arm64 platforms.
v7:
-Updated commit text for macro inclusion
-Updated channel ID bound checks
-Fixed non-uniform placement of function parameters to be within 80 characters -Sent to correct Maintainer email ID
v6:
-Updated the MHI_RANDOM_U32_NONZERO to only give a random number upto the supplied bitmask
v5:
-Updated the macro MHI_RANDOM_U32_NONZERO to take a bitmask as the input parameter and output a non-zero value between 1 and U32_MAX
v4:
-Dropped the change: bus: mhi: core: WARN_ON for malformed vector table -Updated bus: mhi: core: Read transfer length from an event properly to include parse rsc events
-Use prandom_u32_max() instead of prandom_u32 to avoid if check in
bus: mhi: core: Ensure non-zero session or sequence ID values are used
v3:
-Fixed signed-off-by tags
-Add a refactor patch for MHI queue APIs
-Commit text fix in bus: mhi: core: Read transfer length from an event properly -Fix channel ID range check for ctrl and data event rings processing
v2:
-Fix channel ID range check potential infinite loop -Add appropriate signed-off-by tags
Bhaumik Bhatt (4):
bus: mhi: core: Handle firmware load using state worker
bus: mhi: core: Return appropriate error codes for AMSS load failure
bus: mhi: core: Improve debug logs for loading firmware
bus: mhi: core: Ensure non-zero session or sequence ID values are used
Hemant Kumar (4):
bus: mhi: core: Refactor mhi queue APIs
bus: mhi: core: Cache intmod from mhi event to mhi channel
bus: mhi: core: Add range check for channel id received in event ring
bus: mhi: core: Read transfer length from an event properly
drivers/bus/mhi/core/boot.c | 75 +++++++++---------- drivers/bus/mhi/core/init.c | 5 +- drivers/bus/mhi/core/internal.h | 5 +- drivers/bus/mhi/core/main.c | 156 +++++++++++++++++++++------------------- drivers/bus/mhi/core/pm.c | 6 +- include/linux/mhi.h | 2 - 6 files changed, 129 insertions(+), 120 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project