tracing/kprobes: Fix event generation API etc.
Get series with b4
b4 am 158779373972.6082.16695832932765258919.stgit@devnote2Versions newest first
- v1 Latest3 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tracing/kprobes: Fix a double initialization typokernel/ | +1 | 0 replies | |
| 2/3 | tracing/boottime: Fix kprobe event API usagekernel/ | +8 | 3 replies | |
| 3/3 | tracing/kprobes: Reject new event if loc is NULLkernel/ | +6 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Tom Zanussi |
|---|---|
| 1/3 | |
| 2/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] tracing/kprobes: Fix event generation API etc.
Hello,
Here are bugfix/cleanup patches for the kprobe tracer, [1/3] is a typo fix, [2/3] is fixing boot-time tracer and [3/3] is error checking for the new in-kernel kprobe event API.
Tom, I found that your commit 29a154810546 ("tracing: Change trace_boot to use kprobe_event interface") broke the boot-time tracer's kprobe event because of wrong API usage. Could you review it?
I marked [3/3] as a bugfix, because if the loc == NULL, __kprobe_event_gen_cmd_start() obviously does not work. But it reports actual error at kprobe_event_gen_cmd_end(). That is not good for developers to debug it.
Thank you,
---
Masami Hiramatsu (3):
tracing/kprobes: Fix a double initialization typo tracing/boottime: Fix kprobe event API usage tracing/kprobes: Reject new event if loc is NULL
kernel/trace/trace_boot.c | 20 ++++++++------------ kernel/trace/trace_kprobe.c | 8 +++++++- 2 files changed, 15 insertions(+), 13 deletions(-)
--
Masami Hiramatsu (Linaro) <[email protected]>