Skip to content

tracing/kprobes: Fix event generation API etc.

Masami Hiramatsu lkml 1 version In review

Get series with b4
b4 am 158779373972.6082.16695832932765258919.stgit@devnote2

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tracing/kprobes: Fix a double initialization typokernel/trace/trace_kprobe.c+1 -10 replies
2/3tracing/boottime: Fix kprobe event API usagekernel/trace/trace_boot.c+8 -123 replies
3/3tracing/kprobes: Reject new event if loc is NULLkernel/trace/trace_kprobe.c+6 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchTom Zanussi
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] tracing/kprobes: Fix event generation API etc.

Hello,

Here are bugfix/cleanup patches for the kprobe tracer, [1/3] is a typo fix, [2/3] is fixing boot-time tracer and [3/3] is error checking for the new in-kernel kprobe event API.

Tom, I found that your commit 29a154810546 ("tracing: Change trace_boot to use kprobe_event interface") broke the boot-time tracer's kprobe event because of wrong API usage. Could you review it?

I marked [3/3] as a bugfix, because if the loc == NULL, __kprobe_event_gen_cmd_start() obviously does not work. But it reports actual error at kprobe_event_gen_cmd_end(). That is not good for developers to debug it.

Thank you,

---

Masami Hiramatsu (3):
tracing/kprobes: Fix a double initialization typo tracing/boottime: Fix kprobe event API usage tracing/kprobes: Reject new event if loc is NULL

 kernel/trace/trace_boot.c   |   20 ++++++++------------
 kernel/trace/trace_kprobe.c |    8 +++++++-
 2 files changed, 15 insertions(+), 13 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>