Skip to content

Introduce features and debugfs/sysfs entries for MHI

Bhaumik Bhatt linux-arm-msm lkml oe-kbuild-all 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 5 repliesIn review
  2. v611 patches 4 repliesSuperseded
  3. v510 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches13 repliesSuperseded
v37 patches10 repliesSuperseded
v26 patches0 repliesSuperseded
v16 patches1 replySuperseded

Changes in v7 from the cover letter

-Added suggested-by and reviewed-by tags
-Fixed nitpick on removal of M3_fast counter as it was unused -Updated sysfs documentation dates and intended kernel version -Fixed minor debugfs formatting by removing an extra newline character

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declarationdrivers/bus/mhi/core/internal.h+0 -10 replies
2/11bus: mhi: core: Abort suspends due to outgoing pending packetsdrivers/bus/mhi/core/pm.c+4 -20 replies
3/11bus: mhi: core: Use helper API to trigger a non-blocking host resumedrivers/bus/mhi/core/internal.h drivers/bus/mhi/core/main.c drivers/bus/mhi/core/pm.c+18 -230 replies
4/11bus: mhi: core: Trigger host resume if suspended during mhi_device_get()drivers/bus/mhi/core/pm.c+3 -00 replies
5/11bus: mhi: core: Use generic name field for an MHI devicedrivers/bus/mhi/core/init.c drivers/bus/mhi/core/main.c include/linux/mhi.h+10 -90 replies
6/11bus: mhi: core: Introduce helper function to check device statedrivers/bus/mhi/core/internal.h+5 -00 replies
7/11bus: mhi: core: Introduce counters to track MHI device state transitionsdrivers/bus/mhi/core/pm.c include/linux/mhi.h+6 -00 replies
8/11bus: mhi: core: Introduce debugfs entries for MHIdrivers/bus/mhi/Kconfig drivers/bus/mhi/core/Makefile drivers/bus/mhi/core/debugfs.c +3 more+452 -31 reply
9/11bus: mhi: core: Read and save device hardware information from BHIdrivers/bus/mhi/core/boot.c include/linux/mhi.h+22 -10 replies
10/11bus: mhi: core: Introduce APIs to allocate and free the MHI controllerdrivers/bus/mhi/core/init.c include/linux/mhi.h+28 -00 replies
11/11bus: mhi: core: Introduce sysfs entries for MHIDocumentation/ABI/stable/sysfs-bus-mhi MAINTAINERS drivers/bus/mhi/core/init.c+75 -01 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJeffrey HugoManivannan Sadhasivam
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b R-b
6/11R-b R-b
7/11R-b
8/11R-b
9/11R-b R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/11] Introduce features and debugfs/sysfs entries for MHI

Save hardware information from BHI.
Allow reading and modifying some MHI variables for debug, test, and informational purposes using debugfs.
Read values for device specific hardware information to be used by OEMs in factory testing such as serial number and PK hash using sysfs.

This set of patches was tested on arm64 and x86.

v7:
-Added suggested-by and reviewed-by tags
-Fixed nitpick on removal of M3_fast counter as it was unused -Updated sysfs documentation dates and intended kernel version -Fixed minor debugfs formatting by removing an extra newline character

v6:
-Introduced APIs for allocating and freeing the MHI controller so as to ensure that it is always zero-initialized
-Moved gerrits around for counter introduction
-Fixed documentation for sysfs

v5:
-Removed the debug entry to trigger reset and will be addressed in a seperate patch
-Added patch bus: mhi: core: Use counters to track MHI device state transitions -Updated helper API to trigger a non-blocking host resume
-Minor nitpicks also fixed

v4:
-Removed bus: mhi: core: Introduce independent voting mechanism patch -Removed bus vote function from debugfs due to independent voting removal -Added helper resume APIs to aid consolidation of spread out code -Added a clean-up patch and a missing host resume in voting API

v3:
-Add patch to check for pending packets in suspend as a dependency for the independent voting mechanism introduction
-Include register dump entry for debugfs to dump MHI, BHI, and BHIe registers -Update commit message for the debugfs patch
-Updated Documentation/ABI with the required info for sysfs -Updated debugfs patch to include a new KConfig entry and dependencies -Updated reviewed-by for some patches

v2:
-Added a new debugfs.c file for specific debugfs entries and code -Updated commit text and addressed some comments for voting change -Made sure sysfs is only used for serial number and OEM PK hash usage

Bhaumik Bhatt (11):
bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task()
declaration
bus: mhi: core: Abort suspends due to outgoing pending packets
bus: mhi: core: Use helper API to trigger a non-blocking host resume
bus: mhi: core: Trigger host resume if suspended during
mhi_device_get()
bus: mhi: core: Use generic name field for an MHI device
bus: mhi: core: Introduce helper function to check device state
bus: mhi: core: Introduce counters to track MHI device state
transitions
bus: mhi: core: Introduce debugfs entries for MHI
bus: mhi: core: Read and save device hardware information from BHI
bus: mhi: core: Introduce APIs to allocate and free the MHI controller
bus: mhi: core: Introduce sysfs entries for MHI

 Documentation/ABI/stable/sysfs-bus-mhi |  21 ++
 MAINTAINERS                            |   1 +
 drivers/bus/mhi/Kconfig                |   8 +
 drivers/bus/mhi/core/Makefile          |   5 +-
 drivers/bus/mhi/core/boot.c            |  17 +-
 drivers/bus/mhi/core/debugfs.c         | 409 +++++++++++++++++++++++++++++++++
 drivers/bus/mhi/core/init.c            |  81 ++++++-
 drivers/bus/mhi/core/internal.h        |  37 ++-
 drivers/bus/mhi/core/main.c            |  27 +--
 drivers/bus/mhi/core/pm.c              |  26 ++-
 include/linux/mhi.h                    |  30 ++-
 11 files changed, 623 insertions(+), 39 deletions(-)
 create mode 100644 Documentation/ABI/stable/sysfs-bus-mhi
 create mode 100644 drivers/bus/mhi/core/debugfs.c
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project