Skip to content

Extend coredump functionality

Rishabh Bhatnagar linux-remoteproc lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 7 repliesIn review
  2. v73 of 4 patches 5 repliesSuperseded
  3. v63 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v53 patches0 repliesSuperseded
v43 patches2 repliesSuperseded
v33 patches6 repliesSuperseded

v8 -> v7 from the cover letter

- Split out the qcom_q6v5_mss refactoring into a new patch
- Remove zero size check in dump_segment function for mss
- Remove segment number being passed as private member for the segment
- Free the memory used by dump state header before signalling completion

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5remoteproc: Move coredump functionality to a new filedrivers/remoteproc/Makefile drivers/remoteproc/remoteproc_core.c drivers/remoteproc/remoteproc_coredump.c +1 more+209 -1910 replies
2/5remoteproc: qcom_q6v5_mss: Replace mask based tracking with sizedrivers/remoteproc/qcom_q6v5_mss.c+8 -91 reply
3/5remoteproc: Pass size and offset as arguments to segment dump functiondrivers/remoteproc/qcom_q6v5_mss.c drivers/remoteproc/remoteproc_coredump.c include/linux/remoteproc.h+11 -93 replies
4/5remoteproc: Add inline coredump functionalitydrivers/remoteproc/remoteproc_coredump.c include/linux/remoteproc.h+154 -183 replies
5/5remoteproc: Add coredump debugfs entrydrivers/remoteproc/remoteproc_debugfs.c+90 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSibi SankarBjorn AnderssonMathieu Poirier
1/5R-b T-b R-b R-b
2/5R-b
3/5T-b R-b R-b R-b
4/5T-b R-b R-b R-b
5/5T-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/5] Extend coredump functionality

This patch series moves the coredump functionality to a separate file and adds "inline" coredump feature. Inline coredump directly copies segments from device memory during coredump to userspace. This avoids extra memory usage at the cost of speed. Recovery is stalled until all data is read by userspace.
This patchset also includes Sibi Sankar's patch to deal with chunk sizes lesser than segment size to make inline coredump work for modem.
https://patchwork.kernel.org/patch/11637157/

Changelog:

v8 -> v7:
- Split out the qcom_q6v5_mss refactoring into a new patch
- Remove zero size check in dump_segment function for mss
- Remove segment number being passed as private member for the segment
- Free the memory used by dump state header before signalling completion

v7 -> v6:
- Include Sibi's patch as part of this patchset
- Add a linefeed when displaying coredump conf in debugfs
- Fix a typo in remoteproc.h

v6 -> v5:
- Fix unsigned comaprison with negative bug found on gcc-9.3.0

v5 -> v4:
- Rebase on top of linux-next
- Modify qcom_q6v5_mss driver as a result of rebasing on latest tip.

v4 -> v3:
- Write a helper function to copy segment memory for every dump format
- Change segment dump fn to add offset and size adn covert mss driver

v3 -> v2:
- Move entire coredump functionality to remoteproc_coredump.c
- Modify rproc_coredump to perform dump according to conf. set by userspace
- Move the userspace configuration to debugfs from sysfs.
- Keep the default coredump implementation as is

v2 -> v1:
- Introduce new file for coredump.
- Add userspace sysfs configuration for dump type.

Rishabh Bhatnagar (4):
remoteproc: Move coredump functionality to a new file
remoteproc: Add size and offset arguments to segment dump function
remoteproc: Add inline coredump functionality
remoteproc: Add coredump debugfs entry

Sibi Sankar (1):
remoteproc: qcom_q6v5_mss: Replace mask based tracking with size

 drivers/remoteproc/Makefile              |   1 +
 drivers/remoteproc/qcom_q6v5_mss.c       |  25 ++-
 drivers/remoteproc/remoteproc_core.c     | 191 ------------------
 drivers/remoteproc/remoteproc_coredump.c | 325 +++++++++++++++++++++++++++++++
 drivers/remoteproc/remoteproc_debugfs.c  |  90 +++++++++
 drivers/remoteproc/remoteproc_internal.h |   4 +
 include/linux/remoteproc.h               |  21 +-
 7 files changed, 451 insertions(+), 206 deletions(-)
 create mode 100644 drivers/remoteproc/remoteproc_coredump.c
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project