Support for fdb ECMP nexthop groups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 1 replyIn review
- v35 patches 0 repliesSuperseded
- v25 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 9 replies | Superseded |
Changes in v4 from the cover letter
- fix error path free_skb in vxlan_xmit_nh
- fix atomic notifier initialization issue (Reported-by: kernel test robot <[email protected]>) The reported error was easy to locate and fix, but i was not able to re-test with the robot reproducer script due to some other issues with running the script on my test system.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | nexthop: support for fdb ecmp nexthopsinclude/ include/ include/ +2 more | +148 | 0 replies | |
| 2/5 | vxlan: ecmp support for mac fdb entriesdrivers/ include/ include/ +1 more | +275 | 0 replies | |
| 3/5 | nexthop: add support for notifiersinclude/ include/ net/ | +40 | 0 replies | |
| 4/5 | vxlan: support for nexthop notifiersdrivers/ | +29 | 0 replies | |
| 5/5 | selftests: net: add fdb nexthop teststools/ | +158 | 0 replies |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | David Ahern |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v4 0/5] Support for fdb ECMP nexthop groups
From: Roopa Prabhu <[email protected]>
This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps) belonging to the same multi-homed ethernet segment (This is analogous to a multi-homed LAG but over vxlan).
Changes include new nexthop flag NHA_FDB for nexthops referenced by fdb entries. These nexthops only have ip. The patches make sure that routes dont reference such nexthops.
example:
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
$bridge fdb add 02:02:00:00:00:13 dev vxlan1000 nhid 101 self
[1] E-VPN https://tools.ietf.org/html/rfc7432
[2] E-VPN VxLAN: https://tools.ietf.org/html/rfc8365
[3] LPC talk with mention of nexthop groups for L2 ecmp
http://vger.kernel.org/lpc_net2018_talks/scaling_bridge_fdb_database_slidesV3.pdf
v4 -
- fix error path free_skb in vxlan_xmit_nh
- fix atomic notifier initialization issue (Reported-by: kernel test robot <[email protected]>) The reported error was easy to locate and fix, but i was not able to re-test with the robot reproducer script due to some other issues with running the script on my test system.
v3 - fix wording in selftest print as pointed out by davidA
v2 -
- dropped nikolays fixes for nexthop multipath null pointer deref (he will send those separately)
- added negative tests for route add with fdb nexthop + a few more
- Fixes for a few fdb replace conditions found during more testing
- Moved to rcu_dereference_rtnl in vxlan_fdb_info and consolidate rcu dereferences
- Fixes to build failures Reported-by: kbuild test robot <[email protected]>
- DavidA, I am going to send a separate patch for the neighbor code validation for NDA_NH_ID if thats ok.
Roopa Prabhu (5):
nexthop: support for fdb ecmp nexthops
vxlan: ecmp support for mac fdb entries
nexthop: add support for notifiers
vxlan: support for nexthop notifiers
selftests: net: add fdb nexthop tests
drivers/net/vxlan.c | 340 ++++++++++++++++++++++------ include/net/ip6_fib.h | 1 + include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 44 ++++ include/net/vxlan.h | 25 ++ include/uapi/linux/neighbour.h | 1 + include/uapi/linux/nexthop.h | 3 + net/core/neighbour.c | 2 + net/ipv4/nexthop.c | 159 +++++++++++-- net/ipv6/route.c | 5 + tools/testing/selftests/net/fib_nexthops.sh | 160 ++++++++++++- 11 files changed, 651 insertions(+), 90 deletions(-)
Signature · 1 line
2.1.4