Skip to content

Support for Tegra video capture from external sensor

Sowjanya Komatineni linux-devicetree linux-media linux-tegra lkml oe-kbuild-all 10 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest10 patches 0 repliesNew
  2. v910 patches 9 repliesSuperseded
  3. v810 patches 36 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v710 patches2 repliesSuperseded
v6 RFC10 patches9 repliesSuperseded
v5 RFC14 patches25 repliesApplied
v4 RFC14 patches9 repliesSuperseded
v3 RFC18 patches25 repliesApplied
v2 RFC18 patches30 repliesSuperseded
v1 RFC18 patches9 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10media: tegra-video: Fix channel format alignmentdrivers/staging/media/tegra-video/vi.c+3 -130 replies
2/10media: tegra-video: Enable TPG based on kernel configdrivers/staging/media/tegra-video/Kconfig drivers/staging/media/tegra-video/csi.c drivers/staging/media/tegra-video/tegra210.c +2 more+65 -210 replies
3/10media: tegra-video: Update format lookup to offset baseddrivers/staging/media/tegra-video/vi.c+6 -40 replies
4/10dt-bindings: tegra: Update VI and CSI bindings with port infoDocumentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt+90 -20 replies
5/10media: tegra-video: Separate CSI stream enable and disable implementationsdrivers/staging/media/tegra-video/csi.c+35 -160 replies
6/10media: tegra-video: Add support for external sensor capturedrivers/staging/media/tegra-video/Kconfig drivers/staging/media/tegra-video/TODO drivers/staging/media/tegra-video/csi.c +4 more+800 -640 replies
7/10media: tegra-video: Add support for selection ioctl opsdrivers/staging/media/tegra-video/vi.c+106 -00 replies
8/10gpu: host1x: mipi: Keep MIPI clock enabled and mutex locked till calibration donedrivers/gpu/drm/tegra/dsi.c drivers/gpu/host1x/mipi.c include/linux/host1x.h+14 -160 replies
9/10media: tegra-video: Add CSI MIPI pads calibrationdrivers/staging/media/tegra-video/TODO drivers/staging/media/tegra-video/csi.c drivers/staging/media/tegra-video/csi.h +1 more+84 -90 replies
10/10media: tegra-video: Compute settle times based on the clock ratedrivers/staging/media/tegra-video/TODO drivers/staging/media/tegra-video/csi.c drivers/staging/media/tegra-video/csi.h +1 more+75 -30 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchDmitry OsipenkoRob Herring
1/10
2/10
3/10
4/10A-b
5/10R-b
6/10
7/10
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 00/10] Support for Tegra video capture from external sensor

This series adds support for video capture from external camera sensor to Tegra video driver.

Jetson TX1 has camera expansion connector and supports custom camera module designed as per TX1 design specification.

This series also enables camera capture support for Jetson Nano which has Raspberry PI camera header.

This series is tested with IMX274 and IMX219 camera sensors.

This series include,

Tegra video driver updates
- TPG Vs Non-TPG based on Kconfig
- Support for external sensor video capture based on device graph from DT
- Support for selection ioctl operations
- Tegra MIPI CSI pads calibration
- CSI T-CLK and T-HS settle time computation based on clock rates
- dt-binding doc update

Host1x driver updates
- Keep MIPI clock enabled till calibration is done

Delta between patch versions:
[v10]: Includes
- Patch-0009: correction to error variable used in dev_warn message.

[v9]: Includes below fix
- Remove cancel_calibration() added during v4 and use finish_calibrate for pass/fail paths after start_calibrate.
- Fix to keep MIPI clock enabled and mutex locked till end of calibration along with 75usec wait time after calibration start to make sure it finishes its finite sequence codes before waiting for pads LP-11 state.

[v8]: Includes below minor changes
- Fixed missing of_node_put and updated error message to be more informative in tegra_csi_channels_alloc() and tegra_vi_channels_alloc()

Patch-0006 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v7]: Includes minor feedback from v6
- Patch-0009 has minor update

Note:
Patch-0006 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v6]: Includes below changes based on v5 feedback
- Patches are based on latest linux-next.
- separated stream enable and disable implementations into separate functions for tegra_channel_set_stream() and tegra_csi_s_stream().
- changed dev_err to dev_warn on MIPI calibration failure after sensor streaming as its not critical error.

Note:
Patch-0006 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v5]: Includes below minor change based on v4 feedback
Patch-0012: renames APIs to use calibration instead of calibrate.

Note:
Patch-0010 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v4]: Includes below fix based on v3 feedback
- Patches are based on latest linux-next.
- With split of tegra_mipi_calibrate() and tegra_mipi_wait(), mipi clock is not left enabled till calibration done. This series adds a patch to fix this by keeping clock enabled till calibration is done.

Note:
Patch-0010 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v3]: Includes v2 feedback
- Uses separate helper function for retrieving remote csi subdevice and source subdevice.
- Added check for presence of subdevice ops set/get_selection
- dropped vb2_queue_release from driver and using vb2_video_unregister_device instead of video_unregister_device.
- video device register should happen in the last after all video device related setup is done in the driver. This is being addressed in below RFC patch. Once proper implementation of this is available will update Tegra video driver to use split APIs and do all setup prior to device register. Added this as TODO in the driver.
https://www.spinics.net/lists/linux-media/msg172761.html

Note:
Patch-0012 has compilation dependency on
https://patchwork.kernel.org/patch/11659521/

[v2]: Includes below changes based on v1 feedback
- dt-binding document and the driver update for device graph to use separate ports for sink endpoint and source endpoint for csi.
- Use data-lanes endpoint property for csi.
- Update tegra_mipi_request() to take device node pointer argument rather than adding extra API.
- Remove checking for clk pointer before clk_disable.

Sowjanya Komatineni (10):
media: tegra-video: Fix channel format alignment
media: tegra-video: Enable TPG based on kernel config
media: tegra-video: Update format lookup to offset based
dt-bindings: tegra: Update VI and CSI bindings with port info
media: tegra-video: Separate CSI stream enable and disable
implementations
media: tegra-video: Add support for external sensor capture
media: tegra-video: Add support for selection ioctl ops
gpu: host1x: mipi: Keep MIPI clock enabled and mutex locked till
calibration done
media: tegra-video: Add CSI MIPI pads calibration
media: tegra-video: Compute settle times based on the clock rate

 .../display/tegra/nvidia,tegra20-host1x.txt        |  92 ++-
 drivers/gpu/drm/tegra/dsi.c                        |   4 +-
 drivers/gpu/host1x/mipi.c                          |  22 +-
 drivers/staging/media/tegra-video/Kconfig          |   7 +
 drivers/staging/media/tegra-video/TODO             |   6 -
 drivers/staging/media/tegra-video/csi.c            | 314 +++++++-
 drivers/staging/media/tegra-video/csi.h            |   8 +
 drivers/staging/media/tegra-video/tegra210.c       |  25 +-
 drivers/staging/media/tegra-video/vi.c             | 840 +++++++++++++++++++--
 drivers/staging/media/tegra-video/vi.h             |  25 +-
 drivers/staging/media/tegra-video/video.c          |  23 +-
 include/linux/host1x.h                             |   4 +-
 12 files changed, 1250 insertions(+), 120 deletions(-)
Signature · 1 line
2.7.4