Skip to content

iommu/arm-smmu-v3: Improve cmdq lock efficiency

John Garry linux-arm-kernel linux-iommu lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iommu/arm-smmu-v3: Fix trivial typodrivers/iommu/arm-smmu-v3.c+1 -10 replies
2/4iommu/arm-smmu-v3: Calculate bits for prod and ownerdrivers/iommu/arm-smmu-v3.c+60 -40 replies
3/4iommu/arm-smmu-v3: Always issue a CMD_SYNC per batchdrivers/iommu/arm-smmu-v3.c+39 -470 replies
4/4iommu/arm-smmu-v3: Remove cmpxchg() in arm_smmu_cmdq_issue_cmdlist()drivers/iommu/arm-smmu-v3.c+61 -409 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] iommu/arm-smmu-v3: Improve cmdq lock efficiency

As mentioned in [0], the CPU may consume many cycles processing arm_smmu_cmdq_issue_cmdlist(). One issue we find is the cmpxchg() loop to get space on the queue takes approx 25% of the cycles for this function.

This series removes that cmpxchg().

For my NVMe test with 3x NVMe SSDs, I'm getting a ~24% throughput increase:
Before: 1310 IOPs
After: 1630 IOPs

I also have a test harness to check the rate of DMA map+unmaps we can achieve:

CPU count 32 64 128
Before: 63187 19418 10169
After: 93287 44789 15862

(unit is map+unmaps per CPU per second)

[0] https://lore.kernel.org/linux-iommu/B926444035E5E2439431908E3842AFD24B86DB@DGGEMI525-MBS.china.huawei.com/T/#ma02e301c38c3e94b7725e685757c27e39c7cbde3

John Garry (4):
iommu/arm-smmu-v3: Fix trivial typo
iommu/arm-smmu-v3: Calculate bits for prod and owner iommu/arm-smmu-v3: Always issue a CMD_SYNC per batch iommu/arm-smmu-v3: Remove cmpxchg() in arm_smmu_cmdq_issue_cmdlist()

 drivers/iommu/arm-smmu-v3.c | 233 +++++++++++++++++++++++-------------
 1 file changed, 151 insertions(+), 82 deletions(-)
Signature · 1 line
2.26.2