Skip to content

net: bcmgenet: use hardware padding of runt frames

Doug Berger lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: bcmgenet: re-remove bcmgenet_hfb_add_filterdrivers/net/ethernet/broadcom/genet/bcmgenet.c+0 -771 reply
2/3net: bcmgenet: use __be16 for htons(ETH_P_IP)drivers/net/ethernet/broadcom/genet/bcmgenet.c+2 -11 reply
3/3net: bcmgenet: use hardware padding of runt framesdrivers/net/ethernet/broadcom/genet/bcmgenet.c+3 -51 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchFlorian Fainelli
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

Now that scatter-gather and tx-checksumming are enabled by default it revealed a packet corruption issue that can occur for very short fragmented packets.

When padding these frames to the minimum length it is possible for the non-linear (fragment) data to be added to the end of the linear header in an SKB. Since the number of fragments is read before the padding and used afterward without reloading, the fragment that should have been consumed can be tacked on in place of part of the padding.

The third commit in this set corrects this by removing the software padding and allowing the hardware to add the pad bytes if necessary.

The first two commits resolve warnings observed by the kbuild test robot and are included here for simplicity of application.

Doug Berger (3):
net: bcmgenet: re-remove bcmgenet_hfb_add_filter
net: bcmgenet: use __be16 for htons(ETH_P_IP)
net: bcmgenet: use hardware padding of runt frames

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 88 ++------------------------
 1 file changed, 5 insertions(+), 83 deletions(-)
Signature · 1 line
2.7.4