Skip to content

bnxt_en update.

Michael Chan netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 1 replyIn review
  2. v110 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10bnxt_en: Remove PCIe non-counters from ethtool statisticsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+1 -790 replies
2/10bnxt_en: Update firmware interface to 1.10.1.54.drivers/infiniband/hw/bnxt_re/hw_counters.c drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h +3 more+391 -1310 replies
3/10bnxt_en: Use macros to define port statistics size and offset.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+11 -50 replies
4/10bnxt_en: Refactor statistics code and structures.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c +1 more+76 -890 replies
5/10bnxt_en: Allocate additional memory for all statistics blocks.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+26 -50 replies
6/10bnxt_en: Retrieve hardware counter masks from firmware if available.drivers/net/ethernet/broadcom/bnxt/bnxt.c+64 -00 replies
7/10bnxt_en: Retrieve hardware masks for port counters.drivers/net/ethernet/broadcom/bnxt/bnxt.c+70 -50 replies
8/10bnxt_en: Accumulate all counters.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+90 -20 replies
9/10bnxt_en: Switch over to use the 64-bit software accumulated counters.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c+64 -530 replies
10/10bnxt_en: Add support for 'ethtool -d'drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +1 more+94 -00 replies

Reviews trailers per patch

8 of 10 patches have a Reviewed-by or Acked-by.

PatchVasundhara VolamEdwin PeerPavan Chebbi
1/10
2/10R-b R-b
3/10R-b R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH net-next v2 00/10] bnxt_en update.

This patchset removes the PCIe histogram and other debug register data from ethtool -S. The removed data are not counters and they have very large and constantly fluctuating values that are not suitable for the ethtool -S decimal counter display.

The rest of the patches implement counter rollover for all hardware counters that are not 64-bit counters. Different generations of hardware have different counter widths. The driver will now query the counter widths of all counters from firmware and implement rollover support on all non-64-bit counters.

The last patch adds the PCIe histogram and other PCIe register data back using the ethtool -d interface.

v2: Fix bnxt_re RDMA driver compile issue.

Michael Chan (8):
bnxt_en: Update firmware interface to 1.10.1.54.
bnxt_en: Use macros to define port statistics size and offset.
bnxt_en: Refactor statistics code and structures.
bnxt_en: Allocate additional memory for all statistics blocks.
bnxt_en: Retrieve hardware counter masks from firmware if available.
bnxt_en: Retrieve hardware masks for port counters.
bnxt_en: Accumulate all counters.
bnxt_en: Switch over to use the 64-bit software accumulated counters.

Vasundhara Volam (2):
bnxt_en: Remove PCIe non-counters from ethtool statistics
bnxt_en: Add support for 'ethtool -d'

 drivers/infiniband/hw/bnxt_re/hw_counters.c       |   2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 494 ++++++++++++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  96 ++++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c     |   2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 138 +++---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h |   2 +
 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h     | 468 ++++++++++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c   |   2 +-
 8 files changed, 861 insertions(+), 343 deletions(-)
Signature · 1 line
1.8.3.1