Skip to content

Add PCIe and its clock support for mt7622

Henry Yen u-boot 1 version In review

Get series with b4
b4 am 1597323219.5539.20.camel@mtksdccf07

Versions newest first

  1. v1 Latest0 of 5 patches 1 replyIn review

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchFrank Wunderlich
SeriesT-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Add PCIe and its clock support for mt7622
Quoted 105 lines · Henry Yen

Chuanjia Liu schrieb am 10.08.20 um 10:17:

Quoted 12 lines

This series patchs add PCIe/clock support for MT7622

change node:

v1:add PCIe support for MT7622

Chuanjia Liu (5):

clk: mediatek: add pciesys support for MT7622 SoC

Quoted 7 lines

arm: dts: mediatek: add pciesys support for MT7622 SoC

PCI: mediatek: Add PCIe support for MT7622

arm: dts: mediatek: add PCIe node for MT7622

configs: mt7622: add PCIe controller related configs

Hi,

Tested on bananapi-r64 with an mt7612 in slot cn8 and compex wle900vx in cn25.

BPI-R64> pci enum

PCI: Failed autoconfig bar 10

PCI: Failed autoconfig bar 10

BPI-R64> pci 0

Scanning PCI devices on bus 0

BusDevFun VendorId DeviceId Device Class Sub-Class

_____________________________________________________________

00.00.00 0x14c3 0x3258 Bridge device 0x04

00.01.00 0x14c3 0x3258 Bridge device 0x04

BPI-R64> pci 1

Scanning PCI devices on bus 1

BusDevFun VendorId DeviceId Device Class Sub-Class

_____________________________________________________________

01.00.00 0x168c 0x003c Network controller 0x80

BPI-R64>

if i swap the cards

BPI-R64> pci enum

Port1 link down

PCI: Failed autoconfig bar 10

BPI-R64> pci 0

Scanning PCI devices on bus 0

BusDevFun VendorId DeviceId Device Class Sub-Class

_____________________________________________________________

00.00.00 0x14c3 0x3258 Bridge device 0x04

BPI-R64> pci 1

Scanning PCI devices on bus 1

BusDevFun VendorId DeviceId Device Class Sub-Class

_____________________________________________________________

01.00.00 0x14c3 0x7612 Network controller 0x80

BPI-R64>

note that there are pcie-HW-issues on my boards revision(power limitation and missing capacitors on tx-lines) which may cause the different Pcie-Ids for mt7612 and the class of the compex-card. sorry had not seen this before on tests with Steven

Quoted 6 lines

maybe anyone can test the Patches with a fixed board.

regards Frank

Hi Frank,

We've verified the patchset on a fixed board.

The result shows that no matter how I swap the cards, it all works fine :)

Here are the logs:

=========================================
MT7622> pci enum
PCI: Failed autoconfig bar 10
PCI: Failed autoconfig bar 10
MT7622> pci 0
Scanning PCI devices on bus 0
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________

00.00.00   0x14c3     0x3258     Bridge device           0x04
00.01.00   0x14c3     0x3258     Bridge device           0x04

MT7622> pci 1
Scanning PCI devices on bus 1
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________
01.00.00 0x14c3 0x7603 Network controller 0x80
MT7622> pci 2
Scanning PCI devices on bus 2
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________
02.00.00 0x14c3 0x7662 Network controller 0x80

---------------------------------------

MT7622> pci enum
PCI: Failed autoconfig bar 10
PCI: Failed autoconfig bar 10
MT7622> pci 0
Scanning PCI devices on bus 0
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________

00.00.00   0x14c3     0x3258     Bridge device           0x04
00.01.00   0x14c3     0x3258     Bridge device           0x04

MT7622> pci 1
Scanning PCI devices on bus 1
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________
01.00.00 0x14c3 0x7662 Network controller 0x80
MT7622> pci 2
Scanning PCI devices on bus 2
BusDevFun VendorId DeviceId Device Class Sub-Class
_____________________________________________________________
02.00.00 0x14c3 0x7603 Network controller 0x80

=========================================

Thanks !

Sincerely,
Henry

Quoted 1 line