Skip to content

Modularize RPMH driver

Maulik Shah linux-arm-msm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 1 replyIn review
  2. v2 posting 1/22 patches 5 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Update commit message in patch 1
- send [4] again instead of revert's revert in patch 2.

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh"drivers/soc/qcom/rpmh-rsc.c+1 -10 replies
2/2soc: qcom: rpmh: Allow RPMH driver to be loaded as a moduledrivers/soc/qcom/Kconfig drivers/soc/qcom/rpmh-rsc.c+6 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStephen BoydBjorn AnderssonSai Prakash RanjanUlf Hansson
1/2R-b R-b R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [RESEND v2 0/2] Modularize RPMH driver

Resending the patches rebasing on top of latest linux-next (next-20201002)

Changes in v2:
- Update commit message in patch 1
- send [4] again instead of revert's revert in patch 2.

This series is to modularize RPMH driver

The tracepoint in RPMH driver was changed to _rcuidle variant based on the test results of unmerged series [1] where .power_off callback from genpd reported RCU warnings.

The series which finally got merged [2] uses CPU PM notifications and genpd .power_off callback is not implemented in RPMH driver to invoke rpmh_flush(). The CPU PM notifications are done with RCU non idle in kernel (see cpu_pm_notify() uses rcu_irq_enter_irqson() before notifications)

However using _rcuidle variant prevented RPMH driver to compile as module since these _rcuidle are not exported symbols for tracepoints.

This seris reverts the change [3] to remove _rcuidle variant for tracepoint as its no more valid test case (genpd .power_off is not implemented) and bring backs the change [4] that was reverted due to _rcuidle preventing to become modular.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=243931
[2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=269733
[3] https://lore.kernel.org/r/[email protected]
[4] https://lore.kernel.org/r/[email protected]

John Stultz (1):
soc: qcom: rpmh: Allow RPMH driver to be loaded as a module

Maulik Shah (1):
Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh"

 drivers/soc/qcom/Kconfig    | 2 +-
 drivers/soc/qcom/rpmh-rsc.c | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation